Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix endpoint parameter name conflict #772

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 23, 2023

if a static context param is already using a name, avoid writing it for subsequent lower priority params.

This was already in place for context, client, and built-ins, just missed for static context to context.

For context, no current AWS SDK models have this collision, it was noticed in a feature under development.

@kuhe kuhe requested review from a team as code owners May 23, 2023 16:26
@kuhe kuhe merged commit 5185e17 into smithy-lang:main May 26, 2023
@kuhe kuhe deleted the fix/param-conflict branch May 26, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants