-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix streaming type types when they are required #140
Merged
kstich
merged 2 commits into
smithy-lang:master
from
AllanZhengYP:fix-streaming-type-required
Mar 5, 2020
Merged
Fix streaming type types when they are required #140
kstich
merged 2 commits into
smithy-lang:master
from
AllanZhengYP:fix-streaming-type-required
Mar 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da46fdd
to
1956b16
Compare
1956b16
to
df4da83
Compare
kstich
approved these changes
Mar 5, 2020
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 5, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 5, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
AllanZhengYP
added a commit
to aws/aws-sdk-js-v3
that referenced
this pull request
Mar 5, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* fix streaming member typing for required members * use command input/output shape for public typing instead of shapes in protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
now:
models/index.ts
. So now SDK client uses the ones exported from commands to compose input/output type union, instead of those exported frommodels/index.ts
. Although in most cases they should be the same typesCodegen: aws/aws-sdk-js-v3@ee37569
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.