fix streaming members shape #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the streaming member's shape from Uint8Array to Readable|ReadableStream|Blob * For streaming members in command input, ease the restriction to allow Uint8Array, Buffer and string
kstich
requested changes
Feb 28, 2020
| @@ -186,6 +194,29 @@ private void writeOutputType(String typeName, Optional<StructureShape> outputSha | |||
| } | |||
| } | |||
|
|
|||
| private List<MemberShape> getStramingMembers(StructureShape shape) { | |||
There was a problem hiding this comment.
s/getStramingMembers/getStreamingMembers
| */ | ||
| private void writeStreamingInputType( | ||
| String typeName, | ||
| Optional<StructureShape> inputShape, |
There was a problem hiding this comment.
This should just take the content of the optional, it's already known to exist when this is called and is required by the contents of the function as well.
| writer.write("export type $L = $T;", typeName, symbolProvider.toSymbol(inputShape.get())); | ||
| StructureShape input = inputShape.get(); | ||
| List<MemberShape> streamingMembers = getStramingMembers(input); | ||
| if (!streamingMembers.isEmpty()) { |
There was a problem hiding this comment.
Nit: can this conditional be flipped? Streaming members are less likely to exist as well.
kstich
approved these changes
Mar 2, 2020
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 2, 2020
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 5, 2020
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 5, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 5, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
AllanZhengYP
added a commit
to aws/aws-sdk-js-v3
that referenced
this pull request
Mar 5, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138) * Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* Fix the streaming member's shape from Uint8Array to Readable|ReadableStream|Blob * For streaming members in command input, ease the restriction to allow Uint8Array, Buffer and string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uint8Array, Buffer and string
updated
PutObjectCommandInput:Only command input that has streaming member is updated.
Fixes: aws/aws-sdk-js-v3#843
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.