From eacef3305a352843cfb2e587b39b8e5e328967f7 Mon Sep 17 00:00:00 2001
From: John Harrison <jargh@amazon.com>
Date: Sun, 18 Aug 2024 21:05:47 -0700
Subject: [PATCH] Fix comment banner descriptions of p384_montjscalarmul
 argument sizes

As pointed out by June Lee in the code review, the various forms of
the new function p384_montjscalarmul[_alt] all had the same typo in
the comment banner of the code, where the Jacobian points were shown
as size 12 instead of 3*6 = 18. The actual C header files in
include/s2n-bignum*.h were already correct.
---
 arm/p384/p384_montjscalarmul.S         | 6 +++---
 arm/p384/p384_montjscalarmul_alt.S     | 6 +++---
 x86/p384/p384_montjscalarmul.S         | 6 +++---
 x86/p384/p384_montjscalarmul_alt.S     | 6 +++---
 x86_att/p384/p384_montjscalarmul.S     | 6 +++---
 x86_att/p384/p384_montjscalarmul_alt.S | 6 +++---
 6 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/arm/p384/p384_montjscalarmul.S b/arm/p384/p384_montjscalarmul.S
index cd5eccdb..f2413477 100644
--- a/arm/p384/p384_montjscalarmul.S
+++ b/arm/p384/p384_montjscalarmul.S
@@ -3,12 +3,12 @@
 
 // ----------------------------------------------------------------------------
 // Montgomery-Jacobian form scalar multiplication for P-384
-// Input scalar[6], point[12]; output res[12]
+// Input scalar[6], point[18]; output res[18]
 //
 // extern void p384_montjscalarmul
-//   (uint64_t res[static 12],
+//   (uint64_t res[static 18],
 //    uint64_t scalar[static 6],
-//    uint64_t point[static 12]);
+//    uint64_t point[static 18]);
 //
 // This function is a variant of its affine point version p384_scalarmul.
 // Here, input and output points are assumed to be in Jacobian form with
diff --git a/arm/p384/p384_montjscalarmul_alt.S b/arm/p384/p384_montjscalarmul_alt.S
index 73c36cd4..6e2dd56a 100644
--- a/arm/p384/p384_montjscalarmul_alt.S
+++ b/arm/p384/p384_montjscalarmul_alt.S
@@ -3,12 +3,12 @@
 
 // ----------------------------------------------------------------------------
 // Montgomery-Jacobian form scalar multiplication for P-384
-// Input scalar[6], point[12]; output res[12]
+// Input scalar[6], point[18]; output res[18]
 //
 // extern void p384_montjscalarmul_alt
-//   (uint64_t res[static 12],
+//   (uint64_t res[static 18],
 //    uint64_t scalar[static 6],
-//    uint64_t point[static 12]);
+//    uint64_t point[static 18]);
 //
 // This function is a variant of its affine point version p384_scalarmul_alt.
 // Here, input and output points are assumed to be in Jacobian form with
diff --git a/x86/p384/p384_montjscalarmul.S b/x86/p384/p384_montjscalarmul.S
index 71c311ec..469f2623 100644
--- a/x86/p384/p384_montjscalarmul.S
+++ b/x86/p384/p384_montjscalarmul.S
@@ -3,12 +3,12 @@
 
 // ----------------------------------------------------------------------------
 // Montgomery-Jacobian form scalar multiplication for P-384
-// Input scalar[6], point[12]; output res[12]
+// Input scalar[6], point[18]; output res[18]
 //
 // extern void p384_montjscalarmul
-//   (uint64_t res[static 12],
+//   (uint64_t res[static 18],
 //    uint64_t scalar[static 6],
-//    uint64_t point[static 12]);
+//    uint64_t point[static 18]);
 //
 // This function is a variant of its affine point version p384_scalarmul.
 // Here, input and output points are assumed to be in Jacobian form with
diff --git a/x86/p384/p384_montjscalarmul_alt.S b/x86/p384/p384_montjscalarmul_alt.S
index 512ae5ff..c2d1da7c 100644
--- a/x86/p384/p384_montjscalarmul_alt.S
+++ b/x86/p384/p384_montjscalarmul_alt.S
@@ -3,12 +3,12 @@
 
 // ----------------------------------------------------------------------------
 // Montgomery-Jacobian form scalar multiplication for P-384
-// Input scalar[6], point[12]; output res[12]
+// Input scalar[6], point[18]; output res[18]
 //
 // extern void p384_montjscalarmul_alt
-//   (uint64_t res[static 12],
+//   (uint64_t res[static 18],
 //    uint64_t scalar[static 6],
-//    uint64_t point[static 12]);
+//    uint64_t point[static 18]);
 //
 // This function is a variant of its affine point version p384_scalarmul.
 // Here, input and output points are assumed to be in Jacobian form with
diff --git a/x86_att/p384/p384_montjscalarmul.S b/x86_att/p384/p384_montjscalarmul.S
index 5a1d51a6..46fd5ebf 100644
--- a/x86_att/p384/p384_montjscalarmul.S
+++ b/x86_att/p384/p384_montjscalarmul.S
@@ -3,12 +3,12 @@
 
 // ----------------------------------------------------------------------------
 // Montgomery-Jacobian form scalar multiplication for P-384
-// Input scalar[6], point[12]; output res[12]
+// Input scalar[6], point[18]; output res[18]
 //
 // extern void p384_montjscalarmul
-//   (uint64_t res[static 12],
+//   (uint64_t res[static 18],
 //    uint64_t scalar[static 6],
-//    uint64_t point[static 12]);
+//    uint64_t point[static 18]);
 //
 // This function is a variant of its affine point version p384_scalarmul.
 // Here, input and output points are assumed to be in Jacobian form with
diff --git a/x86_att/p384/p384_montjscalarmul_alt.S b/x86_att/p384/p384_montjscalarmul_alt.S
index ad2096db..a3920e9a 100644
--- a/x86_att/p384/p384_montjscalarmul_alt.S
+++ b/x86_att/p384/p384_montjscalarmul_alt.S
@@ -3,12 +3,12 @@
 
 // ----------------------------------------------------------------------------
 // Montgomery-Jacobian form scalar multiplication for P-384
-// Input scalar[6], point[12]; output res[12]
+// Input scalar[6], point[18]; output res[18]
 //
 // extern void p384_montjscalarmul_alt
-//   (uint64_t res[static 12],
+//   (uint64_t res[static 18],
 //    uint64_t scalar[static 6],
-//    uint64_t point[static 12]);
+//    uint64_t point[static 18]);
 //
 // This function is a variant of its affine point version p384_scalarmul.
 // Here, input and output points are assumed to be in Jacobian form with