randomize socket suffix #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you fix the |
|
@brettstack Thanks for the review! I pushed the fixed test just now. |
brettstack
pushed a commit
that referenced
this pull request
Feb 9, 2018
<a name="3.1.3"></a> ## [3.1.3](v3.1.2...v3.1.3) (2018-02-09) ### Bug Fixes * randomize socket suffix ([#120](#120)) ([f747eca](f747eca))
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
<a name="3.1.3"></a> ## [3.1.3](CodeGenieApp/serverless-express@v3.1.2...v3.1.3) (2018-02-09) ### Bug Fixes * randomize socket suffix ([#120](CodeGenieApp/serverless-express#120)) ([f747eca](CodeGenieApp/serverless-express@f747eca))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#109, #5
Description of changes:
Replaced
socketPathSuffixwith random value (generated bygetRandomValue()).Currently, it is a number that increments when
EADDRINUSEoccurs. This implementation may cause a lot of warnings when combined with specific libraries such asserverless-offline.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.