chore: clean up unnecessary TODOs in smithy-swift

[dayaffe]

Describe the feature

The following TODOs can be removed as they are no longer necessary:

https://github.com/smithy-lang/smithy-swift/blob/53fbde27f536f4287edfd4ff08bb5ebe8dc75169/design/DESIGN.md

• let's take a look at this one as a group

// TODO: this file will change post AWS Service config design most likely.

• This file does not seem to have needed any changes as it has not been touched in 2 years

/// TODO: simplify logger creation

• Logger creation seems to work well and does not need to be simplified further

// TODO:: fix indentation when writeInline retains indent

• Indentation issues don't seem pervasive & comment is 2 years old

TODO:: When https://github.com/apple/swift-numerics supports Integer conforming to Real protocol, we need to
change [UInt8] to Complex. Apple's work is being tracked in apple/swift-numerics#5

• ShapeValueGenerator.kt
• SymbolVisitor.kt
• Apple's work is being tracked in Arbitrary-precision bigints apple/swift-numerics#5 & our open issue is Change the [UInt8] to Complex Integer when Apple completes its work #235
• Neither has been touched since they were created. It seems Apple is not going to complete work on this anytime soon.

// TODO create resource type

• the same TODO exists in smithy-python as well
• let's take a look at this one as a group

// TODO: MUST FIX BEFORE SHIPPING. check to see if new synthetic input or output shapes conflict with any other shapes in the model by walking the model and fail code generation

• comment is 2 years old and we haven't run into any issues with conflicting shapes during codegen. next steps / reproduction steps are unclear.
• Let's take a look at this one as a group

// TODO: Support proper deserialization of http response query

• unclear what is improper about our deserialization
• let's take a look at this one as a group

// TODO: Make this pluggable so that this code can exist in aws-sdk-swift

• unclear why we would want this code in aws-sdk-swift as it appears to be a general smithy function that is not specific to AWS

TODO("Organize test suites of smithy-swift and aws-sdk-swift and see if this class and consumers of this class should be moved to aws-sdk-swift OR AWS protocol tests in aws-sdk-swift should be moved to smithy-swift.")

• written by @sichanyoo
• Let's discuss as a group. Maybe we need or have a backlog ticket on examining the state of smithy-swift and what can and should be moved to aws-sdk-swift and vice versa.

Use Case

Clean up repository.

Proposed Solution

Remove unnecessary TODOs to clean up repo.

Other Information

Related issue: #710

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

[sichanyoo]

This document will be moved to Quip, and be edited / revised before being put public again. The document has to be updated with latest design.

[sichanyoo]

// TODO create resource type - check for other SDKs whether this is common across SDKs

[sichanyoo]

Pick up next grooming with // TODO: MUST FIX BEFORE SHIPPING. check to see if new synthetic input or output shapes conflict with any other shapes in the model by walking the model and fail code generation

[dayaffe]

DESIGN.md document will be deleted. I have moved a copy of the raw file to /7wBGA7k8jGyM/Smithy-Swift-SDK-DESIGNmd

[jbelkins]

Released in AWS SDK for Swift 0.32.0