Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 custom treatment of GetBucketLocation response #194

Closed
kggilmer opened this issue Jun 17, 2021 · 5 comments
Closed

s3 custom treatment of GetBucketLocation response #194

kggilmer opened this issue Jun 17, 2021 · 5 comments
Assignees
Labels
good first issue Good for newcomers no-auto-closure We do not want this issue to be automatically closed.

Comments

@kggilmer
Copy link
Contributor

@jdisanti discovered a discrepancy: S3 documentation specifies a form of XML for the response of GetBucketLocation, and then provides an example that does not follow the specification. @rcoh found that the Go SDK had this issue and implemented a customization to deal with this.

Acceptance criteria:

  • responses to the getBucketLocation operation should deserialize as expected into the response properties.
@aajtodd aajtodd transferred this issue from smithy-lang/smithy-kotlin Jul 8, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to provide a comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 2 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 2 days unless further comments are made. labels Jul 8, 2022
@ianbotsf ianbotsf added no-auto-closure We do not want this issue to be automatically closed. and removed closed-for-staleness labels Jul 11, 2022
@ianbotsf ianbotsf reopened this Jul 11, 2022
@aajtodd aajtodd added the good first issue Good for newcomers label Nov 8, 2022
@ianbotsf
Copy link
Contributor

This seems to have been implemented already in #174, albeit not via s3UnwrappedXmlOutput.

@aajtodd
Copy link
Contributor

aajtodd commented Jun 26, 2023

From what I've seen in go we may want to share s3 error deserialization across s3 and s3-control. Basically try both wrapped and unwrapped versions (with the default/first attempt being whatever we think it should be based on the model).

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers no-auto-closure We do not want this issue to be automatically closed.
Projects
None yet
Development

No branches or pull requests

4 participants