v3name_test.cc

/*
 * Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL project
 * 1999.
 */
/* ====================================================================
 * Copyright (c) 1999-2004 The OpenSSL Project.  All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 *
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in
 *    the documentation and/or other materials provided with the
 *    distribution.
 *
 * 3. All advertising materials mentioning features or use of this
 *    software must display the following acknowledgment:
 *    "This product includes software developed by the OpenSSL Project
 *    for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)"
 *
 * 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
 *    endorse or promote products derived from this software without
 *    prior written permission. For written permission, please contact
 *    licensing@OpenSSL.org.
 *
 * 5. Products derived from this software may not be called "OpenSSL"
 *    nor may "OpenSSL" appear in their names without prior written
 *    permission of the OpenSSL Project.
 *
 * 6. Redistributions of any form whatsoever must retain the following
 *    acknowledgment:
 *    "This product includes software developed by the OpenSSL Project
 *    for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)"
 *
 * THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
 * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
 * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE OpenSSL PROJECT OR
 * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
 * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 * OF THE POSSIBILITY OF SUCH DAMAGE.
 * ====================================================================
 *
 * This product includes cryptographic software written by Eric Young
 * (eay@cryptsoft.com).  This product includes software written by Tim
 * Hudson (tjh@cryptsoft.com). */

#include <stdarg.h>
#include <string.h>

#include <gtest/gtest.h>

#include <openssl/crypto.h>
#include <openssl/mem.h>
#include <openssl/x509.h>
#include <openssl/x509v3.h>
#include "openssl/asn1.h"

#include "../internal.h"
#include "internal.h"


static const char *const names[] = {
    "a", "b", ".", "*", "@",
    ".a", "a.", ".b", "b.", ".*", "*.", "*@", "@*", "a@", "@a", "b@", "..",
    "-example.com", "example-.com",
    "@@", "**", "*.com", "*com", "*.*.com", "*com", "com*", "*example.com",
    "*@example.com", "test@*.example.com", "example.com", "www.example.com",
    "test.www.example.com", "*.example.com", "*.www.example.com",
    "test.*.example.com", "www.*.com",
    ".www.example.com", "*www.example.com",
    "example.net", "xn--rger-koa.example.com",
    "*.xn--rger-koa.example.com", "www.xn--rger-koa.example.com",
    "*.good--example.com", "www.good--example.com",
    "*.xn--bar.com", "xn--foo.xn--bar.com",
    "a.example.com", "b.example.com",
    "postmaster@example.com", "Postmaster@example.com",
    "postmaster@EXAMPLE.COM",
    NULL
};

static const char *const exceptions[] = {
    "set CN: host: [*.example.com] matches [a.example.com]",
    "set CN: host: [*.example.com] matches [b.example.com]",
    "set CN: host: [*.example.com] matches [www.example.com]",
    "set CN: host: [*.example.com] matches [xn--rger-koa.example.com]",
    "set CN: host: [*.www.example.com] matches [test.www.example.com]",
    "set CN: host: [*.www.example.com] matches [.www.example.com]",
    "set CN: host: [*www.example.com] matches [www.example.com]",
    "set CN: host: [test.www.example.com] matches [.www.example.com]",
    "set CN: host: [*.xn--rger-koa.example.com] matches [www.xn--rger-koa.example.com]",
    "set CN: host: [*.xn--bar.com] matches [xn--foo.xn--bar.com]",
    "set CN: host: [*.good--example.com] matches [www.good--example.com]",
    "set CN: host-no-wildcards: [*.www.example.com] matches [.www.example.com]",
    "set CN: host-no-wildcards: [test.www.example.com] matches [.www.example.com]",
    "set emailAddress: email: [postmaster@example.com] does not match [Postmaster@example.com]",
    "set emailAddress: email: [postmaster@EXAMPLE.COM] does not match [Postmaster@example.com]",
    "set emailAddress: email: [Postmaster@example.com] does not match [postmaster@example.com]",
    "set emailAddress: email: [Postmaster@example.com] does not match [postmaster@EXAMPLE.COM]",
    "set dnsName: host: [*.example.com] matches [www.example.com]",
    "set dnsName: host: [*.example.com] matches [a.example.com]",
    "set dnsName: host: [*.example.com] matches [b.example.com]",
    "set dnsName: host: [*.example.com] matches [xn--rger-koa.example.com]",
    "set dnsName: host: [*.www.example.com] matches [test.www.example.com]",
    "set dnsName: host-no-wildcards: [*.www.example.com] matches [.www.example.com]",
    "set dnsName: host-no-wildcards: [test.www.example.com] matches [.www.example.com]",
    "set dnsName: host: [*.www.example.com] matches [.www.example.com]",
    "set dnsName: host: [*www.example.com] matches [www.example.com]",
    "set dnsName: host: [test.www.example.com] matches [.www.example.com]",
    "set dnsName: host: [*.xn--rger-koa.example.com] matches [www.xn--rger-koa.example.com]",
    "set dnsName: host: [*.xn--bar.com] matches [xn--foo.xn--bar.com]",
    "set dnsName: host: [*.good--example.com] matches [www.good--example.com]",
    "set rfc822Name: email: [postmaster@example.com] does not match [Postmaster@example.com]",
    "set rfc822Name: email: [Postmaster@example.com] does not match [postmaster@example.com]",
    "set rfc822Name: email: [Postmaster@example.com] does not match [postmaster@EXAMPLE.COM]",
    "set rfc822Name: email: [postmaster@EXAMPLE.COM] does not match [Postmaster@example.com]",
    NULL
};

static int is_exception(const char *msg)
{
    const char *const *p;
    for (p = exceptions; *p; ++p)
        if (strcmp(msg, *p) == 0)
            return 1;
    return 0;
}

static int set_cn(X509 *crt, ...)
{
    int ret = 0;
    X509_NAME *n = NULL;
    va_list ap;
    va_start(ap, crt);
    n = X509_NAME_new();
    if (n == NULL)
        goto out;
    while (1) {
        int nid;
        const char *name;
        nid = va_arg(ap, int);
        if (nid == 0)
            break;
        name = va_arg(ap, const char *);
        if (!X509_NAME_add_entry_by_NID(n, nid, MBSTRING_ASC,
                                        (unsigned char *)name, -1, -1, 1))
            goto out;
    }
    if (!X509_set_subject_name(crt, n))
        goto out;
    ret = 1;
 out:
    X509_NAME_free(n);
    va_end(ap);
    return ret;
}

/*
 * int X509_add_ext(X509 *x, X509_EXTENSION *ex, int loc); X509_EXTENSION
 * *X509_EXTENSION_create_by_NID(X509_EXTENSION **ex, int nid, int crit,
 * ASN1_OCTET_STRING *data); int X509_add_ext(X509 *x, X509_EXTENSION *ex,
 * int loc);
 */

static int set_altname(X509 *crt, ...)
{
    int ret = 0;
    GENERAL_NAMES *gens = NULL;
    GENERAL_NAME *gen = NULL;
    ASN1_IA5STRING *ia5 = NULL;
    va_list ap;
    va_start(ap, crt);
    gens = sk_GENERAL_NAME_new_null();
    if (gens == NULL)
        goto out;
    while (1) {
        int type;
        const char *name;
        type = va_arg(ap, int);
        if (type == 0)
            break;
        name = va_arg(ap, const char *);

        gen = GENERAL_NAME_new();
        if (gen == NULL)
            goto out;
        ia5 = ASN1_IA5STRING_new();
        if (ia5 == NULL)
            goto out;
        if (!ASN1_STRING_set(ia5, name, -1))
            goto out;
        switch (type) {
        case GEN_EMAIL:
        case GEN_DNS:
            GENERAL_NAME_set0_value(gen, type, ia5);
            ia5 = NULL;
            break;
        default:
            abort();
        }
        sk_GENERAL_NAME_push(gens, gen);
        gen = NULL;
    }
    if (!X509_add1_ext_i2d(crt, NID_subject_alt_name, gens, 0, 0))
        goto out;
    ret = 1;
 out:
    ASN1_IA5STRING_free(ia5);
    GENERAL_NAME_free(gen);
    GENERAL_NAMES_free(gens);
    va_end(ap);
    return ret;
}

static int set_cn1(X509 *crt, const char *name)
{
    return set_cn(crt, NID_commonName, name, 0);
}

static int set_cn_and_email(X509 *crt, const char *name)
{
    return set_cn(crt, NID_commonName, name,
                  NID_pkcs9_emailAddress, "dummy@example.com", 0);
}

static int set_cn2(X509 *crt, const char *name)
{
    return set_cn(crt, NID_commonName, "dummy value",
                  NID_commonName, name, 0);
}

static int set_cn3(X509 *crt, const char *name)
{
    return set_cn(crt, NID_commonName, name,
                  NID_commonName, "dummy value", 0);
}

static int set_email1(X509 *crt, const char *name)
{
    return set_cn(crt, NID_pkcs9_emailAddress, name, 0);
}

static int set_email2(X509 *crt, const char *name)
{
    return set_cn(crt, NID_pkcs9_emailAddress, "dummy@example.com",
                  NID_pkcs9_emailAddress, name, 0);
}

static int set_email3(X509 *crt, const char *name)
{
    return set_cn(crt, NID_pkcs9_emailAddress, name,
                  NID_pkcs9_emailAddress, "dummy@example.com", 0);
}

static int set_email_and_cn(X509 *crt, const char *name)
{
    return set_cn(crt, NID_pkcs9_emailAddress, name,
                  NID_commonName, "www.example.org", 0);
}

static int set_altname_dns(X509 *crt, const char *name)
{
    return set_altname(crt, GEN_DNS, name, 0);
}

static int set_altname_email(X509 *crt, const char *name)
{
    return set_altname(crt, GEN_EMAIL, name, 0);
}

struct set_name_fn {
    int (*fn) (X509 *, const char *);
    const char *name;
    int host;
    int email;
};

static const struct set_name_fn name_fns[] = {
    {set_cn1, "set CN", 1, 0},
    {set_cn2, "set CN", 1, 0},
    {set_cn3, "set CN", 1, 0},
    {set_cn_and_email, "set CN", 1, 0},
    {set_email1, "set emailAddress", 0, 1},
    {set_email2, "set emailAddress", 0, 1},
    {set_email3, "set emailAddress", 0, 1},
    {set_email_and_cn, "set emailAddress", 0, 1},
    {set_altname_dns, "set dnsName", 1, 0},
    {set_altname_email, "set rfc822Name", 0, 1},
    {NULL, NULL, 0, 0},
};

static X509 *make_cert(void)
{
    X509 *ret = NULL;
    X509 *crt = NULL;
    X509_NAME *issuer = NULL;
    crt = X509_new();
    if (crt == NULL)
        goto out;
    if (!X509_set_version(crt, 3))
        goto out;
    ret = crt;
    crt = NULL;
 out:
    X509_NAME_free(issuer);
    return ret;
}

static int errors;

static void check_message(const struct set_name_fn *fn, const char *op,
                          const char *nameincert, int match, const char *name)
{
    char msg[1024];
    if (match < 0)
        return;
    BIO_snprintf(msg, sizeof(msg), "%s: %s: [%s] %s [%s]",
                 fn->name, op, nameincert,
                 match ? "matches" : "does not match", name);
    if (is_exception(msg))
        return;
    puts(msg);
    ++errors;
}

static void run_cert(X509 *crt, const char *nameincert,
                     const struct set_name_fn *fn)
{
    const char *const *pname = names;
    while (*pname) {
        int samename = OPENSSL_strcasecmp(nameincert, *pname) == 0;
        size_t namelen = strlen(*pname);
        char *name = (char *)malloc(namelen);
        int match, ret;
        OPENSSL_memcpy(name, *pname, namelen);

        ret = X509_check_host(crt, name, namelen, 0, NULL);
        match = -1;
        if (ret < 0) {
            fprintf(stderr, "internal error in X509_check_host\n");
            ++errors;
        } else if (fn->host) {
            if (ret == 1 && !samename)
                match = 1;
            if (ret == 0 && samename)
                match = 0;
        } else if (ret == 1)
            match = 1;
        check_message(fn, "host", nameincert, match, *pname);

        ret = X509_check_host(crt, name, namelen,
                              X509_CHECK_FLAG_NO_WILDCARDS, NULL);
        match = -1;
        if (ret < 0) {
            fprintf(stderr, "internal error in X509_check_host\n");
            ++errors;
        } else if (fn->host) {
            if (ret == 1 && !samename)
                match = 1;
            if (ret == 0 && samename)
                match = 0;
        } else if (ret == 1)
            match = 1;
        check_message(fn, "host-no-wildcards", nameincert, match, *pname);

        ret = X509_check_email(crt, name, namelen, 0);
        match = -1;
        if (fn->email) {
            if (ret && !samename)
                match = 1;
            if (!ret && samename && strchr(nameincert, '@') != NULL)
                match = 0;
        } else if (ret)
            match = 1;
        check_message(fn, "email", nameincert, match, *pname);
        ++pname;
        free(name);
    }
}

// TODO(davidben): Convert this test to GTest more thoroughly.
TEST(X509V3Test, NameTest) {
    const struct set_name_fn *pfn = name_fns;
    while (pfn->name) {
        const char *const *pname = names;
        while (*pname) {
            // The common name fallback requires the name look sufficiently
            // DNS-like.
            if (strcmp(pfn->name, "set CN") == 0 &&
                !x509v3_looks_like_dns_name(
                    reinterpret_cast<const unsigned char*>(*pname),
                    strlen(*pname))) {
                ++pname;
                continue;
            }
            bssl::UniquePtr<X509> crt(make_cert());
            ASSERT_TRUE(crt);
            ASSERT_TRUE(pfn->fn(crt.get(), *pname));
            run_cert(crt.get(), *pname, pfn);
            ++pname;
        }
        ++pfn;
    }
    EXPECT_EQ(0, errors);
}

struct gennamedata {
    const unsigned char der[22];
    size_t derlen;
} gennames[] = {
    {
        /*
        * [0] {
        *   OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.2.1 }
        *   [0] {
        *     SEQUENCE {}
        *   }
        * }
        */
        {
            0xa0, 0x13, 0x06, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04,
            0x01, 0x84, 0xb7, 0x09, 0x02, 0x01, 0xa0, 0x02, 0x30, 0x00
        },
        21
    }, {
        /*
        * [0] {
        *   OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.2.1 }
        *   [0] {
        *     [APPLICATION 0] {}
        *   }
        * }
        */
        {
            0xa0, 0x13, 0x06, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04,
            0x01, 0x84, 0xb7, 0x09, 0x02, 0x01, 0xa0, 0x02, 0x60, 0x00
        },
        21
    }, {
        /*
        * [0] {
        *   OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.2.1 }
        *   [0] {
        *     UTF8String { "a" }
        *   }
        * }
        */
        {
            0xa0, 0x14, 0x06, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04,
            0x01, 0x84, 0xb7, 0x09, 0x02, 0x01, 0xa0, 0x03, 0x0c, 0x01, 0x61
        },
        22
    }, {
        /*
        * [0] {
        *   OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.2.2 }
        *   [0] {
        *     UTF8String { "a" }
        *   }
        * }
        */
        {
            0xa0, 0x14, 0x06, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04,
            0x01, 0x84, 0xb7, 0x09, 0x02, 0x02, 0xa0, 0x03, 0x0c, 0x01, 0x61
        },
        22
    }, {
        /*
        * [0] {
        *   OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.2.1 }
        *   [0] {
        *     UTF8String { "b" }
        *   }
        * }
        */
        {
            0xa0, 0x14, 0x06, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04,
            0x01, 0x84, 0xb7, 0x09, 0x02, 0x01, 0xa0, 0x03, 0x0c, 0x01, 0x62
        },
        22
    }, {
        /*
        * [0] {
        *   OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.2.1 }
        *   [0] {
        *     BOOLEAN { TRUE }
        *   }
        * }
        */
        {
            0xa0, 0x14, 0x06, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04,
            0x01, 0x84, 0xb7, 0x09, 0x02, 0x01, 0xa0, 0x03, 0x01, 0x01, 0xff
        },
        22
    }, {
        /*
        * [0] {
        *   OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.2.1 }
        *   [0] {
        *     BOOLEAN { FALSE }
        *   }
        * }
        */
        {
            0xa0, 0x14, 0x06, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04,
            0x01, 0x84, 0xb7, 0x09, 0x02, 0x01, 0xa0, 0x03, 0x01, 0x01, 0x00
        },
        22
    }, {
        /* [1 PRIMITIVE] { "a" } */
        {
            0x81, 0x01, 0x61
        },
        3
    }, {
        /* [1 PRIMITIVE] { "b" } */
        {
            0x81, 0x01, 0x62
        },
        3
    }, {
        /* [2 PRIMITIVE] { "a" } */
        {
            0x82, 0x01, 0x61
        },
        3
    }, {
        /* [2 PRIMITIVE] { "b" } */
        {
            0x82, 0x01, 0x62
        },
        3
    }, {
        /*
        * [4] {
        *   SEQUENCE {
        *     SET {
        *       SEQUENCE {
        *         # commonName
        *         OBJECT_IDENTIFIER { 2.5.4.3 }
        *         UTF8String { "a" }
        *       }
        *     }
        *   }
        * }
        */
        {
            0xa4, 0x0e, 0x30, 0x0c, 0x31, 0x0a, 0x30, 0x08, 0x06, 0x03, 0x55,
            0x04, 0x03, 0x0c, 0x01, 0x61
        },
        16
    }, {
        /*
        * [4] {
        *   SEQUENCE {
        *     SET {
        *       SEQUENCE {
        *         # commonName
        *         OBJECT_IDENTIFIER { 2.5.4.3 }
        *         UTF8String { "b" }
        *       }
        *     }
        *   }
        * }
        */
        {
            0xa4, 0x0e, 0x30, 0x0c, 0x31, 0x0a, 0x30, 0x08, 0x06, 0x03, 0x55,
            0x04, 0x03, 0x0c, 0x01, 0x62
        },
        16
    },
#if 0
/* There is currently a bug which prevents AWS-LC from parsing correct encodings
 * of EDIPARTYNAME.
 * Enable these tests when this bug has been fixed. */
      {
        /*
        * [5] {
        *   [1] {
        *     UTF8String { "a" }
        *   }
        * }
        */
        {
            0xa5, 0x05, 0xa1, 0x03, 0x0c, 0x01, 0x61
        },
        7
    }, {
        /*
        * [5] {
        *   [1] {
        *     UTF8String { "b" }
        *   }
        * }
        */
        {
            0xa5, 0x05, 0xa1, 0x03, 0x0c, 0x01, 0x62
        },
        7
    }, {
        /*
        * [5] {
        *   [0] {
        *     UTF8String {}
        *   }
        *   [1] {
        *     UTF8String { "a" }
        *   }
        * }
        */
        {
            0xa5, 0x09, 0xa0, 0x02, 0x0c, 0x00, 0xa1, 0x03, 0x0c, 0x01, 0x61
        },
        11
    }, {
        /*
        * [5] {
        *   [0] {
        *     UTF8String { "a" }
        *   }
        *   [1] {
        *     UTF8String { "a" }
        *   }
        * }
        */
        {
            0xa5, 0x0a, 0xa0, 0x03, 0x0c, 0x01, 0x61, 0xa1, 0x03, 0x0c, 0x01,
            0x61
        },
        12
    }, {
        /*
        * [5] {
        *   [0] {
        *     UTF8String { "b" }
        *   }
        *   [1] {
        *     UTF8String { "a" }
        *   }
        * }
        */
        {
            0xa5, 0x0a, 0xa0, 0x03, 0x0c, 0x01, 0x62, 0xa1, 0x03, 0x0c, 0x01,
            0x61
        },
        12
    },
#endif
       {
        /* [6 PRIMITIVE] { "a" } */
        {
            0x86, 0x01, 0x61
        },
        3
    }, {
        /* [6 PRIMITIVE] { "b" } */
        {
            0x86, 0x01, 0x62
        },
        3
    }, {
        /* [7 PRIMITIVE] { `11111111` } */
        {
            0x87, 0x04, 0x11, 0x11, 0x11, 0x11
        },
        6
    }, {
        /* [7 PRIMITIVE] { `22222222`} */
        {
            0x87, 0x04, 0x22, 0x22, 0x22, 0x22
        },
        6
    }, {
        /* [7 PRIMITIVE] { `11111111111111111111111111111111` } */
        {
            0x87, 0x10, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
            0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11
        },
        18
    }, {
        /* [7 PRIMITIVE] { `22222222222222222222222222222222` } */
        {
            0x87, 0x10, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22,
            0x22, 0x22, 0x22, 0x22, 0x22, 0x22, 0x22
        },
        18
    }, {
        /* [8 PRIMITIVE] { 1.2.840.113554.4.1.72585.2.1 } */
        {
            0x88, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04, 0x01, 0x84,
            0xb7, 0x09, 0x02, 0x01
        },
        15
    }, {
        /* [8 PRIMITIVE] { 1.2.840.113554.4.1.72585.2.2 } */
        {
            0x88, 0x0d, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x12, 0x04, 0x01, 0x84,
            0xb7, 0x09, 0x02, 0x02
        },
        15
    }
};

#define AWSLC_NELEM(x) (sizeof(x)/sizeof((x)[0]))

static int test_GENERAL_NAME_cmp(void)
{
    size_t i = 0;
    size_t j = 0;
    GENERAL_NAME **namesa = (GENERAL_NAME **) OPENSSL_malloc(sizeof(*namesa) * AWSLC_NELEM(gennames));
    GENERAL_NAME **namesb = (GENERAL_NAME **) OPENSSL_malloc(sizeof(*namesb) * AWSLC_NELEM(gennames));
    int testresult = 0; /* Error */

    OPENSSL_cleanse(namesa, sizeof(*namesa) * AWSLC_NELEM(gennames));
    OPENSSL_cleanse(namesb, sizeof(*namesb) * AWSLC_NELEM(gennames));

    if ((NULL == namesa) || (NULL == namesb)) {
        goto end;
    }

    for (i = 0; i < AWSLC_NELEM(gennames); i++) {
        const unsigned char *derp = gennames[i].der;

        /*
         * We create two versions of each GENERAL_NAME so that we ensure when
         * we compare them they are always different pointers.
         */
        namesa[i] = d2i_GENERAL_NAME(NULL, &derp, gennames[i].derlen);
        derp = gennames[i].der;
        namesb[i] = d2i_GENERAL_NAME(NULL, &derp, gennames[i].derlen);
        if ((NULL == namesa[i]) || (NULL == namesb[i])) {
            goto end;
        }
    }

    /* Every name should be equal to itself and not equal to any others. */
    for (i = 0; i < AWSLC_NELEM(gennames); i++) {
        for (j = 0; j < AWSLC_NELEM(gennames); j++) {
            if (i == j) {
                /* Expect equal */
                if (0 != GENERAL_NAME_cmp(namesa[i], namesb[j])) {
                    goto end;
                }
            } else {
                /* Expect not equal */
                if (0 == GENERAL_NAME_cmp(namesa[i], namesb[j])) {
                    goto end;
                }
            }
        }
    }

    testresult = 1;

 end:
    for (i = 0; i < AWSLC_NELEM(gennames); i++) {
        if (namesa != NULL) {
            GENERAL_NAME_free(namesa[i]);
        }
        if (namesb != NULL) {
            GENERAL_NAME_free(namesb[i]);
        }
    }
    OPENSSL_free(namesa);
    OPENSSL_free(namesb);

    /* Returns 1 if success and 0 otherwise */
    return testresult;
}

static int test_edipartyname_GENERAL_NAME_cmp(void) {

    /* Define edipartyname structures directly */

    /*
    * [5] {
    *   [1] {
    *     UTF8String { "a" }
    *   }
    * }
    */
    ASN1_UTF8STRING partynameAa = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameA = {
        NULL, // nameAssigner 
        &partynameAa // partyName 
    };

    GENERAL_NAME gennameAa;
    gennameAa.type = GEN_EDIPARTY;
    gennameAa.d.ediPartyName = &edipartynameA;

    ASN1_UTF8STRING partynameBa = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameBa = {
        NULL, // nameAssigner 
        &partynameBa // partyName 
    };

    GENERAL_NAME gennameBa;
    gennameBa.type = GEN_EDIPARTY;
    gennameBa.d.ediPartyName = &edipartynameBa;

    /*
    * [5] {
    *   [1] {
    *     UTF8String { "b" }
    *   }
    * }
    */
    ASN1_UTF8STRING partynameAb = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "b", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameAb = {
        NULL, // nameAssigner 
        &partynameAb // partyName 
    };

    GENERAL_NAME gennameAb;
    gennameAb.type = GEN_EDIPARTY;
    gennameAb.d.ediPartyName = &edipartynameAb;

    ASN1_UTF8STRING partynameBb = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "b", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameBb = {
        NULL, // nameAssigner 
        &partynameBb // partyName 
    };

    GENERAL_NAME gennameBb;
    gennameBb.type = GEN_EDIPARTY;
    gennameBb.d.ediPartyName = &edipartynameBb;

    /*
    * [5] {
    *   [0] {
    *     UTF8String {}
    *   }
    *   [1] {
    *     UTF8String { "a" }
    *   }
    * }
    */
    ASN1_UTF8STRING partynameAea = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    ASN1_UTF8STRING nameAssignerAea = {
        0, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameAea = {
        &nameAssignerAea, // nameAssigner 
        &partynameAea // partyName 
    };

    GENERAL_NAME gennameAea;
    gennameAea.type = GEN_EDIPARTY;
    gennameAea.d.ediPartyName = &edipartynameAea;

    ASN1_UTF8STRING partynameBea = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    ASN1_UTF8STRING nameAssignerBea = {
        0, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameBea = {
        &nameAssignerBea, // nameAssigner 
        &partynameBea // partyName 
    };

    GENERAL_NAME gennameBea;
    gennameBea.type = GEN_EDIPARTY;
    gennameBea.d.ediPartyName = &edipartynameBea;

    /*
    * [5] {
    *   [0] {
    *     UTF8String { "a" }
    *   }
    *   [1] {
    *     UTF8String { "a" }
    *   }
    * }
    */
    ASN1_UTF8STRING partynameAaa = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    ASN1_UTF8STRING nameAssignerAaa = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameAaa = {
        &nameAssignerAaa, // nameAssigner 
        &partynameAaa // partyName 
    };

    GENERAL_NAME gennameAaa;
    gennameAaa.type = GEN_EDIPARTY;
    gennameAaa.d.ediPartyName = &edipartynameAaa;

    ASN1_UTF8STRING partynameBaa = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    ASN1_UTF8STRING nameAssignerBaa = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameBaa = {
        &nameAssignerBaa, // nameAssigner 
        &partynameBaa // partyName 
    };

    GENERAL_NAME gennameBaa;
    gennameBaa.type = GEN_EDIPARTY;
    gennameBaa.d.ediPartyName = &edipartynameBaa;

    /*
    * [5] {
    *   [0] {
    *     UTF8String { "b" }
    *   }
    *   [1] {
    *     UTF8String { "a" }
    *   }
    * }
    */
    ASN1_UTF8STRING partynameAba = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    ASN1_UTF8STRING nameAssignerAba = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "b", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameAba = {
        &nameAssignerAba, // nameAssigner 
        &partynameAba // partyName 
    };

    GENERAL_NAME gennameAba;
    gennameAba.type = GEN_EDIPARTY;
    gennameAba.d.ediPartyName = &edipartynameAba;

    ASN1_UTF8STRING partynameBba = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "a", // data 
        (long) 0 // flags 
    };

    ASN1_UTF8STRING nameAssignerBba = {
        1, // length 
        V_ASN1_UTF8STRING, // type 
        (unsigned char *) "b", // data 
        (long) 0 // flags 
    };

    EDIPARTYNAME edipartynameBba = {
        &nameAssignerBba, // nameAssigner 
        &partynameBba // partyName 
    };

    GENERAL_NAME gennameBba;
    gennameBba.type = GEN_EDIPARTY;
    gennameBba.d.ediPartyName = &edipartynameBba;

    /* Put everything in two arrays */

#define EDIPARTYNAME_NUM_TEST_CASES 5

    GENERAL_NAME * gennameAarr[EDIPARTYNAME_NUM_TEST_CASES] = {
        &gennameAa,
        &gennameAb,
        &gennameAea,
        &gennameAaa,
        &gennameAba
    };

    GENERAL_NAME * gennameBarr[EDIPARTYNAME_NUM_TEST_CASES] = {
        &gennameBa,
        &gennameBb,
        &gennameBea,
        &gennameBaa,
        &gennameBba
    };

    /* Try all combinations and bail if an error is spotted */

    int result = 0; /* Error */

    for (int i = 0; i < EDIPARTYNAME_NUM_TEST_CASES; i++) {
        for (int j = 0; j < EDIPARTYNAME_NUM_TEST_CASES; j++) {
            if (i == j) {
                /* Expect equal */
                if (0 != GENERAL_NAME_cmp(gennameAarr[i], gennameBarr[j])) {
                    goto end;
                }
            }
            else {
                /* Expect not equal */
                if (0 == GENERAL_NAME_cmp(gennameAarr[i], gennameBarr[j])) {
                    goto end;
                }
            }
        }
    }

    result = 1;

end:

    /* Returns 1 if success and 0 otherwise */
    return result;
}

/* TODO Adopt to GTest */
TEST(X509V3Test, GeneralNameTest) {
    ASSERT_EQ(1, test_GENERAL_NAME_cmp());
    ASSERT_EQ(1, test_edipartyname_GENERAL_NAME_cmp());
}