Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support backend app type for "app package" #860

Closed
efekarakus opened this issue Apr 21, 2020 · 0 comments · Fixed by #863
Closed

Support backend app type for "app package" #860

efekarakus opened this issue Apr 21, 2020 · 0 comments · Fixed by #863
Assignees
@efekarakus
Labels
area/svc Issues about services.

Comments

@efekarakus
Copy link
Contributor

Ask

We want to enable ecs-preview app package to output the cfn template for a backend application manifest.
Currently, app package only works for load balanced web applications.

How?

PR #856 makes it easy for us to add a new application type to the stack package.
We need to:

  1. add a BackendApp struct to the stack pkg.
  2. in the "app package" command we need to add a new switch case for a backend app type:
    https://github.com/aws/amazon-ecs-cli-v2/blob/62e5515b4b6ce53173919b665404fc0fd1b76042/internal/pkg/cli/app_package.go#L279-L280

Parent story

#816
@efekarakus efekarakus added the area/svc Issues about services. label Apr 21, 2020
@efekarakus efekarakus self-assigned this Apr 21, 2020
This was referenced Apr 21, 2020
Closed
Merged
@mergify mergify bot closed this as completed in #863 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efekarakus efekarakus

Labels
area/svc Issues about services.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): package backend app manifests
1 participant
@efekarakus