Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "env" subcommands idempotent #660

Closed
SoManyHs opened this issue Feb 13, 2020 · 2 comments
Closed

Make "env" subcommands idempotent #660

SoManyHs opened this issue Feb 13, 2020 · 2 comments
Assignees
Labels
area/env Issues about environments. type/bug Issues that are bugs.

Comments

@SoManyHs
Copy link
Contributor

Currently, env ls depends on a call to Systems Manager to list the environments. However, if the associated CFN stack for that environment has been deleted, env ls will still succeed.

This may also affect issues with adding environments in a pipeline, e.g.

Related:

@SoManyHs SoManyHs added area/env Issues about environments. type/bug Issues that are bugs. labels Feb 13, 2020
@SoManyHs SoManyHs changed the title Make "env ls" idempotent Make "env" subcommands idempotent Feb 14, 2020
@SoManyHs
Copy link
Contributor Author

Similarly, env delete will fail if the CFN stack for the environment was deleted outside of this tool:

~/aws-reinvent-2019-trivia-backend(master)$ ecs-preview env delete

? Which environment would you like to delete? prod

? Which named profile should we use to delete prod? default

? Are you sure you want to delete environment prod from project backend? Yes
✘ Failed to delete environment prod from project backend: failed to find a stack named backend-prod.

~/aws-reinvent-2019-trivia-backend(master)$ ecs-preview env ls
prod
test

@iamhopaul123
Copy link
Contributor

Close this one for now since:

  1. we probably don't need to do it for env ls
  2. for env delete I tried to delete the CFN stack then run env delete, it was successful.
  3. merged in a PR addressing env init problem.

Feel free to reopen it if any idempotency issue concerning env happens!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/env Issues about environments. type/bug Issues that are bugs.
Projects
None yet
Development

No branches or pull requests

2 participants