From cf0a2a9c05717bbd7cc69b22b3ad6d765184f134 Mon Sep 17 00:00:00 2001 From: William Armiros Date: Fri, 7 Aug 2020 00:00:11 -0700 Subject: [PATCH 1/2] added stacktrace to Log error strat --- .../amazonaws/xray/strategy/LogErrorContextMissingStrategy.java | 1 + 1 file changed, 1 insertion(+) diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/LogErrorContextMissingStrategy.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/LogErrorContextMissingStrategy.java index d2bc822a..979ae07b 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/LogErrorContextMissingStrategy.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/LogErrorContextMissingStrategy.java @@ -32,6 +32,7 @@ public class LogErrorContextMissingStrategy implements ContextMissingStrategy { @Override public void contextMissing(String message, Class exceptionClass) { logger.error("Suppressing AWS X-Ray context missing exception (" + exceptionClass.getSimpleName() + "): " + message); + logger.debug(new RuntimeException(message)); } } From 1e2249e36eb4dfe0f1bf83706b42c0dba75f89cf Mon Sep 17 00:00:00 2001 From: William Armiros Date: Fri, 7 Aug 2020 00:12:41 -0700 Subject: [PATCH 2/2] added debug check --- .../xray/strategy/LogErrorContextMissingStrategy.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/LogErrorContextMissingStrategy.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/LogErrorContextMissingStrategy.java index 979ae07b..38746ea3 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/LogErrorContextMissingStrategy.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/LogErrorContextMissingStrategy.java @@ -32,7 +32,8 @@ public class LogErrorContextMissingStrategy implements ContextMissingStrategy { @Override public void contextMissing(String message, Class exceptionClass) { logger.error("Suppressing AWS X-Ray context missing exception (" + exceptionClass.getSimpleName() + "): " + message); - logger.debug(new RuntimeException(message)); + if (logger.isDebugEnabled()) { + logger.debug(new RuntimeException(message)); + } } - }