Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actions to copy logical / physical names to stack viewer #2165

Merged
merged 10 commits into from
Oct 30, 2020
Merged

Add actions to copy logical / physical names to stack viewer #2165

merged 10 commits into from
Oct 30, 2020

Conversation

kiiadi
Copy link
Contributor

@kiiadi kiiadi commented Oct 21, 2020 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
    Screen Shot 2020-10-21 at 4 45 51 PM

Screen Shot 2020-10-21 at 4 45 39 PM

Screen Shot 2020-10-21 at 4 46 00 PM

@kiiadi kiiadi requested a review from a team as a code owner October 21, 2020 23:42
@kiiadi
Copy link
Contributor Author

kiiadi commented Oct 21, 2020

/runUiTests

@kiiadi kiiadi force-pushed the kiiadi/copy-arn-on-stack-viewer branch from 6a95a4f to ba2f71f Compare October 22, 2020 00:09
@kiiadi kiiadi changed the base branch from master to kiiadi/add-resource-tab October 22, 2020 00:09
@kiiadi kiiadi mentioned this pull request Oct 22, 2020
Merged
Base automatically changed from kiiadi/add-resource-tab to master October 22, 2020 17:31
@kiiadi kiiadi force-pushed the kiiadi/copy-arn-on-stack-viewer branch from e0dedd0 to 8e72aab Compare October 22, 2020 17:32
@kiiadi
Copy link
Contributor Author

kiiadi commented Oct 22, 2020 •
edited
Loading

/runUiTests

hunterwerlla
hunterwerlla approved these changes Oct 22, 2020
View reviewed changes
...s-core/src/software/aws/toolkits/jetbrains/services/cloudformation/stack/DynamicTableView.kt Outdated
fun addMouseListener(listener: MouseListener) = table.addMouseListener(listener)

fun selectedRow(): Map<Field<T>, Any?>? {
val row = table.selectedRows?.takeIf { it.size == 1 }?.first() ?: return null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: first seems like it is safe but would still like firstOrNull to guarantee it doesn't throw randomly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@kiiadi kiiadi force-pushed the kiiadi/copy-arn-on-stack-viewer branch from eb1acdc to 7c7ed56 Compare October 22, 2020 23:42
@kiiadi
Copy link
Contributor Author

kiiadi commented Oct 22, 2020 •
edited
Loading

/runUiTest

@kiiadi kiiadi force-pushed the kiiadi/copy-arn-on-stack-viewer branch from 7c7ed56 to afbcff1 Compare October 23, 2020 18:55
@kiiadi kiiadi force-pushed the kiiadi/copy-arn-on-stack-viewer branch from 598d23d to 34861b4 Compare October 29, 2020 20:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kiiadi kiiadi merged commit 57d90c5 into master Oct 30, 2020
@kiiadi kiiadi deleted the kiiadi/copy-arn-on-stack-viewer branch October 30, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterwerlla hunterwerlla hunterwerlla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiiadi @hunterwerlla