feat: support bi-directional transcribe streaming over Websocket #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: uuid not available in rn
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
force-pushed
the
ws-eventstream
branch
from
cf3c4cd to
e98d94d
Compare
alexforsyth
reviewed
May 28, 2020
...ain/java/software/amazon/smithy/aws/typescript/codegen/AddTranscribeStreamingDependency.java
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
alexforsyth
reviewed
May 28, 2020
alexforsyth
approved these changes
May 28, 2020
kstich
reviewed
May 28, 2020
...ain/java/software/amazon/smithy/aws/typescript/codegen/AddTranscribeStreamingDependency.java
Outdated
Show resolved
Hide resolved
Now this package can fully serialize & deserailize eventstream with web APIs. In browsers, it converts from user-side iterables of input structure to internal ReadableStream of binaries. In ReactNative, it converts from user-side iterables of input structure to internal iterables of binaries. The same applies to the other converting direction.
AllanZhengYP
force-pushed
the
ws-eventstream
branch
from
e98d94d to
7e50b36
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
reviewed
May 29, 2020
packages/middleware-sdk-transcribe-streaming/src/websocket-handler.ts
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
reviewed
May 29, 2020
packages/middleware-sdk-transcribe-streaming/src/configuration.ts
Outdated
Show resolved
Hide resolved
packages/middleware-sdk-transcribe-streaming/src/configuration.ts
Outdated
Show resolved
Hide resolved
packages/middleware-sdk-transcribe-streaming/src/middleware-session-id.ts
Outdated
Show resolved
Hide resolved
packages/middleware-sdk-transcribe-streaming/src/middleware-session-id.ts
Outdated
Show resolved
Hide resolved
packages/middleware-sdk-transcribe-streaming/src/middleware-session-id.ts
Show resolved
Hide resolved
packages/middleware-sdk-transcribe-streaming/src/websocket-handler.ts
Outdated
Show resolved
Hide resolved
packages/middleware-sdk-transcribe-streaming/src/websocket-handler.ts
Outdated
Show resolved
Hide resolved
packages/middleware-sdk-transcribe-streaming/src/websocket-handler.ts
Outdated
Show resolved
Hide resolved
packages/middleware-sdk-transcribe-streaming/src/websocket-handler.ts
Outdated
Show resolved
Hide resolved
AllanZhengYP
force-pushed
the
ws-eventstream
branch
from
50bddce to
90ef0e0
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
May 29, 2020
packages/middleware-sdk-transcribe-streaming/src/middleware-session-id.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Trivikram Kamat <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
May 30, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add customizations for Transcribe Streaming client to support bi-directional streaming in browsers over websocket. The client is compatible with ReactNative too. But currently there's no viable solution to access void record in chunks.
The customizations are in the
@aws-sdk/middleware-sdk-transcribe-streamingpackage. They are crafted according to 'Using Amazon Transcribe Streaming with WebSockets'. The customizations are as below:middleware-endpoint: convert original http endpoint to Websocket endpint. Supplying custome endpoints for TranscribeStreaming in browser may lead to unknow behaviormiddleware-session-id: inject defaultsession-idparameter in the request. Because websocket handler doesn't expose the request ID header from the response, we usesession-idto map request to server-side logs. This middleware also inject other non-streaming response parameters likeLanguageCode,MediaEncodeing,MediaSampleRateHertz, so that the SDK behavior is consistent in NodeJS runtime.signer: SigV4-based signer used to sign websocket request. It signs the request by presigning the requestwebsocket-handler: An Websocket handler wrapped in aRequestHandlerinterface. The request's payload can beReadableStreamorAsyncIterable. The response from it has payload inAsyncIterable. But ifReadableStreamconstructor is available in the environment, the response payload is prefered inReadableStream. This is for interface consistency across the browsers. If any error thrown from input stream, the handler will close the WebSocket connection and throw error from response payload stream.TODO: Create a ReactNative library that emits recorder binary chunks so that RN users can supply recorder data to WebSocket API.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.