Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Generate V3 client name and package name according to v3 release #114

Closed
1 task
AllanZhengYP opened this issue Mar 15, 2022 · 3 comments
Closed
1 task
Labels
enhancement New feature or request

Comments

@AllanZhengYP
Copy link

AllanZhengYP commented Mar 15, 2022

Self-service

  • I'd be willing to implement this feature

Description

Currently the V3 package names are static: code, but the upstream V3 SDK repo releases new clients constantly. This is not scalable for maintainers to update this list often.

We can create a workflow to add new package/client names to the metadata automatically, either by periodically checking the V3 repo or triggered by a V3 GitHub release.

@AllanZhengYP AllanZhengYP added the enhancement New feature or request label Mar 15, 2022
@trivikr
Copy link
Member

trivikr commented Mar 15, 2022

Looking at the frequency of additional services being added, and the exceptions between v2 and v3 client names, I think manual updates to clients would require less work.

If we're planning to add a workflow, this is where client names are decided from:

The exception will need to be added in CLIENT_NAMES_MAP.ts only if there's a difference between naming in v2 and v3.

@trivikr
Copy link
Member

trivikr commented Dec 23, 2022

A semi-automation was added in #204 to generate new-client tests from enums. The names need to be verified manually though.

And example update for clients can be viewed at #201

@trivikr trivikr closed this as completed Dec 23, 2022
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants