Remove promise calls when parentPath is CallExpression (#574)

aws · Sep 7, 2023 · dbf3a3f · dbf3a3f
1 parent fef89e4
commit dbf3a3f
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/.changeset/warm-flowers-sell.md b/.changeset/warm-flowers-sell.md
@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Remove promise calls when parentPath is CallExpression
diff --git a/src/transforms/v2-to-v3/__fixtures__/api-promise/call-expression.input.js b/src/transforms/v2-to-v3/__fixtures__/api-promise/call-expression.input.js
@@ -0,0 +1,6 @@
+import AWS from "aws-sdk";
+
+const client = new AWS.DynamoDB();
+
+const promiseArray = [];
+promiseArray.push(client.listTables().promise());
diff --git a/src/transforms/v2-to-v3/__fixtures__/api-promise/call-expression.output.js b/src/transforms/v2-to-v3/__fixtures__/api-promise/call-expression.output.js
@@ -0,0 +1,6 @@
+import { DynamoDB } from "@aws-sdk/client-dynamodb";
+
+const client = new DynamoDB();
+
+const promiseArray = [];
+promiseArray.push(client.listTables());
diff --git a/src/transforms/v2-to-v3/apis/removePromiseForCallExpression.ts b/src/transforms/v2-to-v3/apis/removePromiseForCallExpression.ts
@@ -5,7 +5,10 @@ export const removePromiseForCallExpression = (
   j: JSCodeshift,
   callExpression: ASTPath<CallExpression>
 ) => {
-  switch (callExpression.parentPath.value.type) {
+  const parentPathValue = Array.isArray(callExpression.parentPath.value)
+    ? callExpression.parentPath.value[0]
+    : callExpression.parentPath.value;
+  switch (parentPathValue.type) {
     case "MemberExpression": {
       callExpression.parentPath.value.object = (
         callExpression.value.callee as MemberExpression
@@ -34,6 +37,7 @@ export const removePromiseForCallExpression = (
     // eslint-disable-next-line no-fallthrough
     case "ArrowFunctionExpression":
     case "AwaitExpression":
+    case "CallExpression":
     case "ExpressionStatement":
     case "ObjectProperty":
     case "ReturnStatement":