Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing paginator for S3 ListObjectVersions #1775

Closed
2 tasks
sgavinio opened this issue Jul 25, 2022 · 2 comments
Closed
2 tasks

Missing paginator for S3 ListObjectVersions #1775

sgavinio opened this issue Jul 25, 2022 · 2 comments
Assignees
Labels
contribution/core This is a PR that came from AWS. feature-request A feature should be added or improved.

Comments

@sgavinio
Copy link

sgavinio commented Jul 25, 2022

Describe the feature

This is to report that there is no paginator for the S3 ListObjectVersions operation.

This is part of V1 of the SDK under ListObjectVersionsPagesWithContext and it was present in V2 of the SDK at one time but it was removed for some reason: NewListObjectVersionsPaginator .

Use Case

This functionality is pretty core to listing object versions and simplifies operations involving S3 object versions. This was previously present in V1 and it's absence is a regression from migrating from v1 to v2.

Proposed Solution

Request to implement a paginator for ListObjectVersions similar to the other S3 pagination operations (e.g. ListObjectsV2Paginator)

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go-v2/service/s3 v1.24.0

Go version used

go version go1.18 darwin/amd64
@sgavinio sgavinio added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 25, 2022
@RanVaknin RanVaknin added contribution/core This is a PR that came from AWS. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 19, 2022
@RanVaknin RanVaknin self-assigned this Aug 19, 2022
@RanVaknin
Copy link
Contributor

Hi @sgavinio ,

Thanks for reaching out and bringing his to our attention. Currently we are not able to add this to our backlog.
If others are interested, you can hand-write the paginator, make a PR, and we can integrate it with the SDK.
You can refer to the ListObjectsV2 paginator as an example.

@RanVaknin RanVaknin removed their assignment Aug 29, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@RanVaknin RanVaknin self-assigned this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants