From 3e4a6ee1779e31bf57ad9da0556bdbf733562a83 Mon Sep 17 00:00:00 2001 From: skotambkar Date: Wed, 21 Oct 2020 13:23:33 -0700 Subject: [PATCH] feedback --- .../go/codegen/customization/Route53Customizations.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/Route53Customizations.java b/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/Route53Customizations.java index c02839a9adc..a8bc2e4ce40 100644 --- a/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/Route53Customizations.java +++ b/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/Route53Customizations.java @@ -109,10 +109,11 @@ private void writeHostedZoneIDInputSanitizer( writer.openBlock("case $P :", "", symbolProvider.toSymbol(input), () -> { writer.addUseImports(SmithyGoDependency.STRINGS); for (MemberShape member : hostedZoneIDMembers) { - writer.openBlock("if i.$L != nil {", "}", member.getMemberName(), () -> { - writer.write("values := strings.Split(*i.$L, \"/\")", member.getMemberName()); - writer.write("v := values[len(values)-1]"); - writer.write("i.$L = &v", member.getMemberName()); + String memberName = member.getMemberName(); + writer.openBlock("if i.$L != nil {", "}", memberName, () -> { + writer.write("idx := strings.LastIndex(*i.$L, `/`)", memberName); + writer.write("v := *i.$L[idx+1:]", memberName); + writer.write("i.$L = &v", memberName); }); } });