Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bumping cdk from 1.99.0 to 1.102.0 #415

Merged
merged 2 commits into from
May 11, 2021

Conversation

jusiskin
Copy link
Contributor

Bumps CDK version from 1.96.0 to 1.99.0

Notes

  • CDK upgraded eslint-plugin-jest from 24.3.424.3.6.
    • fixed a bug in the no-conditional-expect rule. RFDK tests that had an expect(...) statement within a condition branch were emitting errors
      • Tests were refactored so that expects were not conditional
    • some tests with the same name within a common scope (e.g. describe block) were also being flagged
      • Tests were refactored to have unique names

Testing

  • Ran yarn build from the root which performs a basic RFDK TypeScript build and runs our regression test suite. All tests passed
  • Deployed the All-In-AWS-Infrastructure-Basic example app successfully

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin added the contribution/core This is a PR that came from AWS. label May 10, 2021
@jusiskin jusiskin requested a review from ddneilson May 10, 2021 22:26
@jusiskin jusiskin merged commit 14f3d8a into aws:mainline May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants