feat(deadline): add ThinkboxDockerImages construct #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusiskin
force-pushed
the
public_deadline_images
branch
from
07fd5b1 to
88ce21b
Compare
jusiskin
changed the title
ddneilson
previously requested changes
Jan 11, 2021
packages/aws-rfdk/lib/lambdas/nodejs/lib/ecr-provider/ecr-provider.ts
Outdated
Show resolved
Hide resolved
jericht
force-pushed
the
public_deadline_images
branch
from
88ce21b to
719a41b
Compare
kozlove-aws
reviewed
Jan 18, 2021
examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/lib/service_tier.py
Outdated
Show resolved
Hide resolved
jericht
force-pushed
the
public_deadline_images
branch
from
23fc72f to
49ee0b2
Compare
jericht
force-pushed
the
public_deadline_images
branch
from
49ee0b2 to
240cc2e
Compare
ryyakobe
requested changes
Jan 20, 2021
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/bin/config.ts
Outdated
Show resolved
Hide resolved
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/lib/service-tier.ts
Outdated
Show resolved
Hide resolved
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/lib/service-tier.ts
Outdated
Show resolved
Hide resolved
packages/aws-rfdk/lib/lambdas/nodejs/lib/ecr-provider/ecr-provider.ts
Outdated
Show resolved
Hide resolved
packages/aws-rfdk/lib/lambdas/nodejs/lib/ecr-provider/ecr-provider.ts
Outdated
Show resolved
Hide resolved
packages/aws-rfdk/lib/lambdas/nodejs/lib/ecr-provider/ecr-provider.ts
Outdated
Show resolved
Hide resolved
yashda
reviewed
Jan 25, 2021
packages/aws-rfdk/lib/lambdas/nodejs/lib/ecr-provider/ecr-provider.ts
Outdated
Show resolved
Hide resolved
ryyakobe
reviewed
Jan 25, 2021
packages/aws-rfdk/lib/lambdas/nodejs/lib/ecr-provider/mock-data.json
Outdated
Show resolved
Hide resolved
ryyakobe
reviewed
Jan 25, 2021
- Also addresses CR feedback
jusiskin
force-pushed
the
public_deadline_images
branch
from
0ed7df7 to
456de85
Compare
ryyakobe
previously approved these changes
Jan 27, 2021
jusiskin
dismissed
ddneilson’s stale review
All requested changes have been resolved
yashda
previously approved these changes
Jan 27, 2021
ryyakobe
reviewed
Jan 28, 2021
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/bin/config.ts
Outdated
Show resolved
Hide resolved
ryyakobe
requested changes
Jan 28, 2021
ddneilson
reviewed
Jan 28, 2021
examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/config.py
Outdated
Show resolved
Hide resolved
ddneilson
reviewed
Jan 28, 2021
ddneilson
reviewed
Jan 28, 2021
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/bin/config.ts
Outdated
Show resolved
Hide resolved
- Also fix up deadline module README
ryyakobe
reviewed
Jan 28, 2021
ryyakobe
previously approved these changes
Jan 28, 2021
jericht
requested changes
Jan 28, 2021
ryyakobe
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
ThinkboxDockerImagesconstruct that can be used to provide AWS Thinkbox published container images for use with theRenderQueueandUsageBasedLicensingconstructs.Modified the documentation and examples to use this instead since it is expected to be the primary way of deploying container images with RFDK.
Testing
Deployed both the TypeScript and Python
AWS-All-in-Basicexamples and ensured that the container images are referenced as specified.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license