fix: Set Amazon Linux version based on Deadline Repository version #1419
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caden Marofke <[email protected]>
marofke
force-pushed
the
al2-backwards-integ-fix
branch
from
2ccb406 to
1d54703
Compare
ariemary-amz
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recent changes to move RFDK infrastructure to Amazon Linux 2023 were causing integration tests to fail when installing the Deadline repository for Deadline versions before 10.4.0.10.
Solution
When we install the Deadline Repository, we check the Deadline version, and fall back to AL2 instances if they are versions older than 10.4.0.
Testing
DEADLINE_VERSION="10.3.2.1"yarn e2efrom the integ directory, confirmed integration tests passedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license