Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto-approve conditional vulnerability #1231

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

loachri
Copy link
Contributor

@loachri loachri commented Aug 21, 2024

It's not secure to automerge dependabot changes without additional metadata. To fix this, we add the github.event.base.repo.id == github.event.head.repo.id conditional as a quick fix to make sure that this restricts the workflow to only execute if the source and target of the PR are the same repo, blocking it from running on any fork-origin PRs.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@loachri loachri force-pushed the loachri/fix-polished branch 2 times, most recently from 17ca5c7 to 052d471 Compare August 21, 2024 21:02
@loachri loachri force-pushed the loachri/fix-polished branch from 052d471 to 7acf98c Compare August 21, 2024 21:05
Copy link
Contributor

@marofke marofke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🦈

@loachri loachri merged commit 6f14682 into mainline Aug 21, 2024
3 checks passed
@loachri loachri deleted the loachri/fix-polished branch August 21, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants