Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement using Construct.construct to stay ahead of deprecation of Construct.node #55

Closed
1 of 2 tasks
ddneilson opened this issue Aug 12, 2020 · 1 comment
Closed
1 of 2 tasks

Implement using Construct.construct to stay ahead of deprecation of Construct.node #55

ddneilson opened this issue Aug 12, 2020 · 1 comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@ddneilson
Copy link
Contributor

ddneilson commented Aug 12, 2020 •
edited by grbartel
Loading

Upstream CDK has deprecated the use of Construct.node in favor of Construct.construct. We'll need to update places where we access through Construct.node to use Construct.construct instead.

Reference: aws/aws-cdk#9557

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ddneilson ddneilson added needs-triage This issue or PR still needs to be triaged. feature-request A feature should be added or improved. labels Aug 12, 2020
@jusiskin
Copy link
Contributor

It appears that this was reverted in aws/aws-cdk#9637 (CDK v1.58.0+) due to aws/jsii#1880. I discussed this with the CDK core team and it sounds like they are sticking with .node for the foreseeable future.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddneilson @jusiskin