Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot update scripts related to the Mountable* classes #368

Closed
ddneilson opened this issue Mar 29, 2021 · 0 comments · Fixed by #369
Closed

Cannot update scripts related to the Mountable* classes #368

ddneilson opened this issue Mar 29, 2021 · 0 comments · Fixed by #369
Assignees
@ddneilson
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. investigating This issue is being investigated and/or work is in progress to resolve the issue.

Comments

@ddneilson
Copy link
Contributor

If altering the shell scripts used by the MountableEfs or MountableEbs helpers then existing deployments will be unable to update. You get an error because CloudFormation cannot delete an export that is use by a different stack. Root cause is the asset bundle being rooted on the Mountable*'s stack, rather than the target's stack.

Reproduction Steps

  1. Deploy our typescript basic all-in example farm at least up to the ServiceTier
  2. Modify node_modules/aws-rfdk/lib/core/scripts/mountEfs.sh in any way (e.g. add a blank line)
  3. Update-deploy the farm.

Environment

  • CDK CLI Version : 1.94.1
  • CDK Framework Version: 1.94.1
  • RFDK Version: 0.28.0
  • Deadline Version: 10.1.14.5
  • Node.js Version: Any
  • OS : Any
  • Language (Version): All

This is 🐛 Bug Report
@ddneilson ddneilson added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 29, 2021
@ddneilson ddneilson self-assigned this Mar 29, 2021
@ddneilson ddneilson added contribution/core This is a PR that came from AWS. investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 29, 2021
@ddneilson ddneilson mentioned this issue Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddneilson ddneilson

Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. investigating This issue is being investigated and/or work is in progress to resolve the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): move mountable's asset to scope of target ddneilson/aws-rfdk
1 participant
@ddneilson