Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax IWorkerFleet to IConnectable in grantPortAccess #351

Closed
ddneilson opened this issue Mar 17, 2021 · 0 comments · Fixed by #352
Closed

Relax IWorkerFleet to IConnectable in grantPortAccess #351

ddneilson opened this issue Mar 17, 2021 · 0 comments · Fixed by #352
Assignees
@ddneilson
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. investigating This issue is being investigated and/or work is in progress to resolve the issue.

Comments

@ddneilson
Copy link
Contributor

More of a design bug...

UsageBasedLicensing.grantPortAccess()'s first argument is presently an IWorkerFleet (see: https://docs.aws.amazon.com/rfdk/api/latest/docs/aws-rfdk.deadline.UsageBasedLicensing.html#grant-wbr-port-wbr-accessworkerfleet-licenses ).

This is needlessly restrictive. The interface only needs to be IConnectable

This comes up when working on a farm architecture that uses a single SecurityGroup for all workers, and trying to allow access on that security group.

This is 🐛 Bug Report
@ddneilson ddneilson added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2021
@ddneilson ddneilson self-assigned this Mar 17, 2021
@ddneilson ddneilson mentioned this issue Mar 17, 2021
Merged
@ddneilson ddneilson added contribution/core This is a PR that came from AWS. investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddneilson ddneilson

Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. investigating This issue is being investigated and/or work is in progress to resolve the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deadline): Relax UsageBasedLicensing.grantPortAccess() to IConnectable ddneilson/aws-rfdk
1 participant
@ddneilson