Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metric path #171

Closed
manute opened this issue Jun 12, 2020 · 3 comments
Closed

Prometheus metric path #171

manute opened this issue Jun 12, 2020 · 3 comments
Labels
Type: Enhancement New feature or request

Comments

@manute
Copy link

manute commented Jun 12, 2020

Hi,

Thanks for this project, it's very useful.

Looking at the documentation I could not find any prometheus path, so Can it be added or do you think is not needed?

I can work on a PR if that's ok.

[edited: typo]

@bwagner5
Copy link
Contributor

I think prometheus metrics could be useful if it's behind a configuration flag. Since NTH is a daemonset, some users may not want to waste the extra overhead of running an http server for metrics if they're not interested in them. Feel free to work on a PR!

@manute
Copy link
Author

manute commented Jun 16, 2020

Hey @bwagner5 , I just created this #172 .

@bwagner5
Copy link
Contributor

bwagner5 commented Jul 1, 2020

released in v1.5.0!

@bwagner5 bwagner5 closed this as completed Jul 1, 2020
@snay2 snay2 removed the Pending-Release Pending an NTH or eks-charts release label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants