Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing DrainEvent metadata for SpotITN #104

Closed
gavinbunney opened this issue Mar 2, 2020 · 2 comments
Closed

Missing DrainEvent metadata for SpotITN #104

gavinbunney opened this issue Mar 2, 2020 · 2 comments
Labels
Type: Bug Something isn't working

Comments

@gavinbunney
Copy link
Contributor

The spot instance termination notice endpoint is only populating the timestamp of the event in the DrainEvent struct.

You can see this in the logs:

Got drain event from channel {EventID: Kind:SPOT_ITN Description:Spot ITN received. will be at 2020-03-02T18:20:55Z

The documentation for the notice API also only indicates a time is returned: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/spot-interruptions.html#instance-action-metadata

Can you confirm that this is working as expected? If so, will probably need to add another step to fetch more instance metadata during these notices, as at the moment the logs (and webhook notifications) are pretty sparse.

Thanks!

Another example of a webhook notice showing the DrainEvent fields not being populated:

image

@mattrandallbecker
Copy link
Contributor

mattrandallbecker commented Mar 2, 2020

Thanks for reporting the issue, we'll investigate the problem. The integration tests we wrote only check if a message was successfully sent, looks like that was a mistake and some of the other data is missing.

You are correct, we'll need to grab this information from the other paths in the metadata service, it should resolve this issue and this other one : #94

@mattrandallbecker mattrandallbecker added the Type: Bug Something isn't working label Mar 2, 2020
@bwagner5
Copy link
Contributor

fixed and released in v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants