-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce required API of source streams. #103
Labels
Comments
Current uses: tell()
close()If we were implementing this new, I would say that we should not try to close the source stream at all. All of these are simply to communicate to other parts of these classes through their use of
closed
|
This was referenced Dec 6, 2018
This is now complete and will be available in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the source stream used by
streaming_client
streams must implement four APIs:read()
tell()
close()
closed
As raised in #80, there are several cases where it would be useful for us to only require
read()
.This leaves the following to be considered for elimination:
tell()
close()
closed
The text was updated successfully, but these errors were encountered: