Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merge-back): 2.52.0 #23109

Merged
merged 5 commits into from
Nov 28, 2022
Merged

chore(merge-back): 2.52.0 #23109

merged 5 commits into from
Nov 28, 2022

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Nov 27, 2022

See CHANGELOG

madeline-k and others added 3 commits November 27, 2022 11:49
See [CHANGELOG.v2.md](https://github.com/aws/aws-cdk/compare/v2-release...2.52.0?expand=1#diff-9e3d5c5da890b65a67bf632f93416744d5b76f6eb239e42ab714c7768429ff99)

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation added auto-approve pr/no-squash This PR should be merged instead of squash-merging it labels Nov 27, 2022
@gitpod-io
Copy link

gitpod-io bot commented Nov 27, 2022

@github-actions github-actions bot added the p2 label Nov 27, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team November 27, 2022 22:44
@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2022
@mergify mergify bot dismissed github-actions[bot]’s stale review November 27, 2022 22:52

Pull request has been modified.

@@ -212,22 +217,21 @@ export class Cluster extends Resource implements ICluster {
this._executeCommandConfiguration = props.executeCommandConfiguration;
}

const cluster = new CfnCluster(this, 'Resource', {
Copy link
Contributor

@ryparker ryparker Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these expected changes? Could this be reverting the changes merged to main after the release branch was created?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change is expected

@madeline-k
Copy link
Contributor

CI is failing because I took the wrong changes in resolving a merge conflict for the CFN spec. Will have that fixed shortly.

github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2022
@mergify mergify bot dismissed github-actions[bot]’s stale review November 27, 2022 23:23

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b50a5e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2022

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b2d0a66 into main Nov 28, 2022
@mergify mergify bot deleted the merge-back/2.52.0 branch November 28, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-approve p2 pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants