chore: make node-bundle's "build" script behave as others #19307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default `projen` build step re-generates the `package.json` file and re-install dependencies, which breaks in case the `align-versions.sh` script was run (as the re-generated `package.json` has version `0.0.0` again). This inserts a hack to reset the `build` script and make it a synonym to the `compile` script. This was breaking the `jsii` integration tests (they try to build, but not test, `aws-cdk`).
|
|
|
IMPORTANT: This is directly on the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
iliapolo
approved these changes
Mar 9, 2022
TheRealAmazonKendra
pushed a commit
to TheRealAmazonKendra/aws-cdk
that referenced
this pull request
Mar 11, 2022
The default `projen` build step re-generates the `package.json` file and re-install dependencies, which breaks in case the `align-versions.sh` script was run (as the re-generated `package.json` has version `0.0.0` again). This inserts a hack to reset the `build` script and make it a synonym to the `compile` script. This was breaking the `jsii` integration tests (they try to build, but not test, `aws-cdk`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
projenbuild step re-generates thepackage.jsonfile andre-install dependencies, which breaks in case the
align-versions.shscript was run (as the re-generated
package.jsonhas version0.0.0again).
This inserts a hack to reset the
buildscript and make it a synonymto the
compilescript.This was breaking the
jsiiintegration tests (they try to build, butnot test,
aws-cdk).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license