Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pipelines): add examples for pipeline variables #19288

Merged
merged 6 commits into from
Mar 9, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 8, 2022

Fixes #19184.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team March 8, 2022 18:13
@rix0rrr rix0rrr self-assigned this Mar 8, 2022
@gitpod-io
Copy link

gitpod-io bot commented Mar 8, 2022

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Mar 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 8, 2022
@rix0rrr rix0rrr added feature-request A feature should be added or improved. and removed contribution/core This is a PR that came from AWS. @aws-cdk/pipelines CDK Pipelines library labels Mar 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 8, 2022
@rix0rrr rix0rrr added p2 and removed feature-request A feature should be added or improved. contribution/core This is a PR that came from AWS. labels Mar 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 8, 2022
@@ -233,7 +233,24 @@ export class CodeBuildStep extends ShellStep {
* The variable must be set in the shell of the CodeBuild step when
* it finishes its `post_build` phase.
*
* ```ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not be here?

@corymhall corymhall added the pr/do-not-merge This PR should not be merged at this time. label Mar 9, 2022
@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Mar 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr added feature-request A feature should be added or improved. and removed p2 contribution/core This is a PR that came from AWS. labels Mar 9, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f6768ff
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a6d52aa into master Mar 9, 2022
@mergify mergify bot deleted the huijbers/var-example branch March 9, 2022 22:59
@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TheRealAmazonKendra pushed a commit to TheRealAmazonKendra/aws-cdk that referenced this pull request Mar 11, 2022
Fixes aws#19184.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipelines.CodePipelineSource.sourceAttribute(): How and when to invoke?
3 participants