feat(eks): using kubectl role for kubectl handler lambda #13378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
aka-toxa
changed the title
github-actions
bot
added
the
@aws-cdk/aws-eks
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
What specifically? We don't have unittests for the lambda handler, the integ tests should cover that. And as far the provider is concerned, I would just a test that validates the role of the handler is the same as Or did you mean something else? |
|
ah yeah I didn't seen that existing integ tests are failed. thought that there is no tests for provider at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue#12107
we remove intermediate IAMRole for kubectl-provider and directly use kubectl role
@iliapolo I have no idea how to properly make a unittests there can you help please?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license