Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(msk): support for Kafka version 3.8.x and add deprecated labels to legacy versions #33553

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Feb 22, 2025

Issue # (if applicable)

N/A

Reason for this change

  • MSK now supports Kafka version 3.8 (Ref)
  • Some versions are already deprecated (Ref

Description of changes

  • Add Kafka version 3.8.x.
  • Add deprecated labels to following versions:
version EOL
2.6.0 2024-09-11
2.6.1 2024-09-11
2.6.2 2024-09-11
2.6.3 2024-09-11
2.7.0 2024-09-11
2.7.1 2024-09-11
2.7.2 2024-09-11
2.8.0 2024-09-11
2.8.1 2024-09-11
2.8.2-tiered 2025-01-14
3.1.1 2024-09-11
3.2.0 2024-09-11
3.3.1 2024-09-11
3.3.2 2024-09-11

Describe any new or updated permissions being added

Nothing.

Description of how you validated changes

Update unit tests and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 22, 2025 02:41
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Feb 22, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (ff658ba) to head (c547150).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33553   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5641     5641           
  Misses       1118     1118           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@mazyu36 mazyu36 marked this pull request as ready for review February 22, 2025 04:15
@mazyu36 mazyu36 changed the title feat(msk): add support for Kafka version 3.8.x and KRaft feat(msk): support for Kafka version 3.8.x and add deprecated labels to legacy versions Feb 22, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 22, 2025 04:16

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 22, 2025
Copy link
Contributor

mergify bot commented Feb 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c547150
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 29623d1 into aws:main Feb 24, 2025
20 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2025
@mazyu36 mazyu36 deleted the feature/msk-3-8 branch February 24, 2025 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants