Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: upgrade ESLint to v9 #32565

Closed
1 of 2 tasks
ren-yamanashi opened this issue Dec 18, 2024 · 3 comments
Closed
1 of 2 tasks

package: upgrade ESLint to v9 #32565

ren-yamanashi opened this issue Dec 18, 2024 · 3 comments
Labels
@aws-cdk/aws-config Related to AWS Config duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@ren-yamanashi
Copy link
Contributor

ren-yamanashi commented Dec 18, 2024

Describe the feature

NOTE: Please note that this proposal is not a feature request , but a change request 🙏
(I could not determine which issue template to propose, so I am proposing a fetrure request...)

Currently v7 of ESLint is used in this repository, but v7 and v8 are now past EOL and should be updated to v9.

see: https://eslint.org/blog/2024/09/eslint-v8-eol-version-support/

Also, v9 changes the way configuration files are written, so I think it is better to write them in flatConfig.
(By specifying environment variables, it is possible to write the configuration file in v9 as it has been written so far (config), but in v10, only flatConfig is fully functional, so it is considered better to change it to flatConfig.

see: https://eslint.org/blog/2023/10/flat-config-rollout-plans/

Use Case

Because ESLint v7 is past EOL.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.166.0

Environment details (OS name and version, etc.)

macOS Sonoma v14.0

@ren-yamanashi ren-yamanashi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 18, 2024
@github-actions github-actions bot added the @aws-cdk/aws-config Related to AWS Config label Dec 18, 2024
@ren-yamanashi ren-yamanashi changed the title upgrade ESLint to v9 package: upgrade ESLint to v9 Dec 18, 2024
@ren-yamanashi
Copy link
Contributor Author

ren-yamanashi commented Dec 18, 2024

Oops, this issue may not be necessary since the following MR was submitte

#32573

@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 18, 2024
@khushail khushail self-assigned this Dec 18, 2024
@khushail
Copy link
Contributor

khushail commented Dec 18, 2024

Thanks for linking the action item which is being worked on @ren-yamanashi.

Marking it as duplicate. Closing this as its already in progress. Please feel free to reopen if not implemented

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 18, 2024
@khushail khushail removed their assignment Dec 18, 2024
@khushail khushail added the duplicate This issue is a duplicate. label Dec 18, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-config Related to AWS Config duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants