Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-s3-deployment): Allow ability to specify versionId for S3 bucket source #32462

Open
2 tasks
nritholtz opened this issue Dec 10, 2024 · 3 comments · May be fixed by #32484
Open
2 tasks

(aws-s3-deployment): Allow ability to specify versionId for S3 bucket source #32462

nritholtz opened this issue Dec 10, 2024 · 3 comments · May be fixed by #32484
Labels
@aws-cdk/aws-s3-deployment effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@nritholtz
Copy link

nritholtz commented Dec 10, 2024

Describe the feature

Allow user to specify optional versionId of the zipped file for the s3 bucket source type.

Use Case

We are using versioning on our s3 bucket and replacing the same file, but want to use versionId instead of having to create duplicate files to deploy to our cloudfront s3 bucket.

Versioning is extremely important for use case, since we use it for lifecycle retention policy purposes (with keep last N versions).

Proposed Solution

new s3Deploy.BucketDeployment(this, 'bucket-deployment', {
            sources: [
                s3Deploy.Source.bucket(sourceBucket, sourceKey, {versionId: '3sL4kqtJlcpXroDTDmJ+rmSpXd3dIbrHY+MTRCxf3vjVBH40Nr8X8gdRQBpUMLUo'}),

where versionId is optional.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.170.0

Environment details (OS name and version, etc.)

MacOS 14.6.1

@nritholtz nritholtz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 10, 2024
@khushail khushail added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Dec 10, 2024
@khushail khushail self-assigned this Dec 10, 2024
@khushail khushail added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 10, 2024
@khushail
Copy link
Contributor

Hi @nritholtz , thanks for requesting this. Mentioning versionId for the S3 Bucket source properties might be useful. Marking it as P3 for community contribution as its a good to have feature.

@khushail khushail added p3 effort/small Small work item – less than a day of effort and removed p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 10, 2024
@khushail khushail removed their assignment Dec 10, 2024
@nritholtz
Copy link
Author

Hey @khushail, I opened a PR for this issue. Just confirming that I did everything correctly here for it to get reviewed, thanks.

@khushail
Copy link
Contributor

khushail commented Dec 16, 2024

Hi @nritholtz , thanks for your contribution. Appreciate your efforts.

I see that the PR has been labelled as needs-community-review, which means trusted community reviewer will first review it and then cdk team member will do the review. You can reach out to CDK Community for fast review, by mentioning it in cdk.dev channel. Let me know if you need any help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3-deployment effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants