Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: CustomResourceConfig has no effect #32380

Closed
1 task
Dreamescaper opened this issue Dec 4, 2024 · 2 comments
Closed
1 task

core: CustomResourceConfig has no effect #32380

Dreamescaper opened this issue Dec 4, 2024 · 2 comments
Assignees
Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@Dreamescaper
Copy link

Dreamescaper commented Dec 4, 2024

Describe the bug

I've added the following lines to my CDK app:

var app = new App();

// Add stacks

CustomResourceConfig.Of(app).AddRemovalPolicy(RemovalPolicy.DESTROY);
CustomResourceConfig.Of(app).AddLogRetentionLifetime(RetentionDays.THREE_MONTHS);

However, it has no effect. BucketNotificationsHandl and CustomS3AutoDeleteObject Log Groups are never expired, and are not removed when CF stack is removed.

image

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

LogGroups have 3 months expiry period and are removed when CF stack is deleted.

Current Behavior

LogGroups have 'Never Expire' period and are not removed when CF stack is deleted.

CDK CLI Version

2.167.2

Node.js Version

20

OS

AmazonLinux

Language

.NET

Language Version

.NET 8

Other information

It is mentioned in comments in this issue: #23909
I decided to add a separate ticket though.

@Dreamescaper Dreamescaper added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2024
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Dec 4, 2024
@khushail
Copy link
Contributor

khushail commented Dec 4, 2024

Hi @Dreamescaper , thanks for reaching out. Could you please share minimal self-contained code that could help reproduce the issue?

@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2024
@khushail khushail self-assigned this Dec 4, 2024
@khushail khushail added the p2 label Dec 4, 2024
Copy link

github-actions bot commented Dec 6, 2024

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants