Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ecs-patterns): desiredTaskCount not a property of aws-ecs-patterns #32056

Closed
spensireli opened this issue Nov 8, 2024 · 3 comments · Fixed by spensireli/aws-cdk#1
Closed
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p3

Comments

@spensireli
Copy link

Describe the issue

If I'm reading this correctly the desiredTaskCount isn't actually a property of queueProcessingEc2Service, so it cannot be specified as it is in the example.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs_patterns.QueueProcessingEc2Service.html

https://github.com/aws/aws-cdk/blame/7bb9203eb95fe894c0d40942ff49c782a9fec251/packages/aws-cdk-lib/aws-ecs-patterns/lib/ecs/queue-processing-ecs-service.ts#L132

@spensireli spensireli added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Nov 8, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Nov 8, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 8, 2024
@khushail khushail self-assigned this Nov 8, 2024
@khushail
Copy link
Contributor

khushail commented Nov 8, 2024

Hi @spensireli , thanks for reporting this. I can confirm that its non existent in QueueProcessingEc2Service construct(QueueProcessingServiceBase).

I found this mention in ECS service where related desiredCount parameter is read from FLAG value to be passed to EC2 Service props.

const desiredCount = FeatureFlags.of(this).isEnabled(cxapi.ECS_REMOVE_DEFAULT_DESIRED_COUNT) ? undefined : this.desiredCount;

If i try to access it, the synth process would give error as its not in the props-

Screenshot 2024-11-08 at 11 00 04 AM

So this seems legit, Marking it as P3 as its a documentation bug, contributions from the community are welcome

@khushail khushail added p3 and removed p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 8, 2024
@khushail khushail removed their assignment Nov 8, 2024
@khushail khushail added the effort/small Small work item – less than a day of effort label Nov 8, 2024
@spensireli
Copy link
Author

Okay thought so, I'll try and find time to craft a PR.

Copy link

github-actions bot commented Nov 9, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p3
Projects
None yet
2 participants