Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk: Warnings on cdk init #31420

Open
1 task
sholtomaud opened this issue Sep 12, 2024 · 2 comments
Open
1 task

aws-cdk: Warnings on cdk init #31420

sholtomaud opened this issue Sep 12, 2024 · 2 comments
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI

Comments

@sholtomaud
Copy link

Describe the bug

Applying project template app for typescript

Welcome to your CDK TypeScript project

This is a blank project for CDK development with TypeScript.

The cdk.json file tells the CDK Toolkit how to execute your app.

Useful commands

  • npm run build compile typescript to js
  • npm run watch watch for changes and compile
  • npm run test perform the jest unit tests
  • npx cdk deploy deploy this stack to your default AWS account/region
  • npx cdk diff compare deployed stack with current state
  • npx cdk synth emits the synthesized CloudFormation template

Executing npm install...
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
✅ All done!

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

no warnings on init

Current Behavior

Applying project template app for typescript

Welcome to your CDK TypeScript project

This is a blank project for CDK development with TypeScript.

The cdk.json file tells the CDK Toolkit how to execute your app.

Useful commands

  • npm run build compile typescript to js
  • npm run watch watch for changes and compile
  • npm run test perform the jest unit tests
  • npx cdk deploy deploy this stack to your default AWS account/region
  • npx cdk diff compare deployed stack with current state
  • npx cdk synth emits the synthesized CloudFormation template

Executing npm install...
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
✅ All done!

Reproduction Steps

npx cdk init app --language=typescript

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

latest

Framework Version

No response

Node.js Version

20

OS

macos

Language

TypeScript

Language Version

No response

Other information

No response

@sholtomaud sholtomaud added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 12, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Sep 12, 2024
@ashishdhingra ashishdhingra changed the title aws-cdk aws-cdk: Warnings on cdk init Sep 12, 2024
@ashishdhingra ashishdhingra self-assigned this Sep 12, 2024
@ashishdhingra
Copy link
Contributor

Reproducible. Following warnings are displayed:

Executing npm install...
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
✅ All done!

@ren-yamanashi
Copy link
Contributor

ren-yamanashi commented Nov 14, 2024

@ashishdhingra

I am considering working on this issue. Therefore, I would like to discuss a few things.

Premise

When I checked the contents of package.lock.json, the issue mentioned in this issue seems to be caused by jest (and related libraries).
(In fact, when I personally removed jest and ran npm install, this error did not occur.)

Therefore, I am considering submitting a PR to modify it to use vitest instead of jest.

Things I Want to Discuss

I would like to discuss the following two points.

1. About the test package

Is it permissible to adopt vitest instead of jest?

2. Testing the initial template

If you update the TypeScript init-template, the TypeScript init tests may fail.
(In fact, the PR to update tsconfig.json below has been reverted.)

#31953

So, I would like to verify the correct operation in MR. Is the following method of verifying the operation correct?

  1. Add a test to the following file
  1. Run the following integ test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

3 participants