Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(eks): Reusable Kubectl Provider for imported clusters #14692

Closed
1 of 2 tasks
SomeoneWeird opened this issue May 14, 2021 · 3 comments
Closed
1 of 2 tasks

(eks): Reusable Kubectl Provider for imported clusters #14692

SomeoneWeird opened this issue May 14, 2021 · 3 comments
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@SomeoneWeird
Copy link

It would be great if we could define reusable a Kubectl Provider for imported clusters with eks.Cluster.fromClusterAttributes.

Use Case

Currently when a cluster is referred to for the first time in a stack it deploys a new NestedStack that contains a single lambda. For accounts with a large number of stacks this can be a problem when getting close to the service limit of 200 stacks per account.

Proposed Solution

Being able to deploy a single provider for a cluster manually, and then do something like

eks.Cluster.fromClusterAttributes({
   ...
   provider: eks.Provider.fromExisting({ ... })
})

Another potentially solution is to change the KubectlProvider from being a NestedStack to being a Construct.

Other

There is already a getOrCreate function that calls _attachKubectlResourceScope, but this would only work for an existing eks.Cluster instance, not one being created using fromClusterAttributes

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@SomeoneWeird SomeoneWeird added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 14, 2021
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label May 14, 2021
@iliapolo iliapolo changed the title aws-eks: Reusable Kubectl Provider for imported clusters (eks): Reusable Kubectl Provider for imported clusters May 17, 2021
@iliapolo
Copy link
Contributor

iliapolo commented May 17, 2021

Related to #12107 #14689

@iliapolo iliapolo added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels May 17, 2021
@iliapolo iliapolo removed their assignment Jun 27, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 28, 2022
@github-actions github-actions bot closed this as completed Jul 3, 2022
@SomeoneWeird
Copy link
Author

This is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants