From 97e9ea083378bb8d4bd96cd1a1f6726d533d27f4 Mon Sep 17 00:00:00 2001 From: Matt Gucci <8044346+matt9ucci@users.noreply.github.com> Date: Sat, 13 Apr 2024 03:00:45 +0900 Subject: [PATCH] chore(eks): remove duplicate test case (#29814) ### Reason for this change The removed case `'throws when a core construct is added as cdk8s chart'` is the same as `'throws when a non cdk8s chart construct is added as cdk8s chart'`. ### Description of changes Removed duplicates. ### Description of how you validated changes Just removed the case. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- packages/aws-cdk-lib/aws-eks/test/cluster.test.ts | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/packages/aws-cdk-lib/aws-eks/test/cluster.test.ts b/packages/aws-cdk-lib/aws-eks/test/cluster.test.ts index 6b7367d6fc5f6..1e4929c9dc5c1 100644 --- a/packages/aws-cdk-lib/aws-eks/test/cluster.test.ts +++ b/packages/aws-cdk-lib/aws-eks/test/cluster.test.ts @@ -350,20 +350,6 @@ describe('cluster', () => { expect(() => cluster.addCdk8sChart('chart', someConstruct)).toThrow(/Invalid cdk8s chart. Must contain a \'toJson\' method, but found undefined/); }); - test('throws when a core construct is added as cdk8s chart', () => { - const { stack } = testFixture(); - - const cluster = new eks.Cluster(stack, 'Cluster', { - version: CLUSTER_VERSION, - prune: false, - }); - - // create a plain construct, not a cdk8s chart - const someConstruct = new Construct(stack, 'SomeConstruct'); - - expect(() => cluster.addCdk8sChart('chart', someConstruct)).toThrow(/Invalid cdk8s chart. Must contain a \'toJson\' method, but found undefined/); - }); - test('cdk8s chart can be added to cluster', () => { const { stack } = testFixture();