Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
mrgrain authored Dec 6, 2022
1 parent b199681 commit 9717a67
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-efs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const fileSystem = new efs.FileSystem(this, 'MyEfsFileSystem', {
});
```

⚠️ An Amazon EFS file system's performance mode can't be MaxIo while its throughputMode is ELASTIC.
⚠️ An Amazon EFS file system's performance mode can't be MAX_IO when its throughputMode is ELASTIC.

⚠️ An Amazon EFS file system's performance mode can't be changed after the file system has been created.
Updating this property will replace the file system.
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-efs/lib/efs-file-system.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ export class FileSystem extends FileSystemBase {
}

if (props.throughputMode === ThroughputMode.ELASTIC && props.performanceMode === PerformanceMode.MAX_IO) {
throw new Error('Elastic ThroughputMode is not supported for file systems with PerformanceMode of MaxIO');
throw new Error('ThroughputMode ELASTIC is not supported for file systems with performanceMode MAX_IO');
}
// we explictly use 'undefined' to represent 'false' to maintain backwards compatibility since
// its considered an actual change in CloudFormations eyes, even though they have the same meaning.
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-efs/test/efs-file-system.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ test('Exception when throughput mode is set to ELASTIC, performance mode cannot
throughputMode: ThroughputMode.ELASTIC,
performanceMode: PerformanceMode.MAX_IO,
});
}).toThrowError(/Elastic ThroughputMode is not supported for file systems with PerformanceMode of MaxIO/);
}).toThrowError(/ThroughputMode ELASTIC is not supported for file systems with performanceMode MAX_IO/);
});

test('Exception when throughput mode is set to PROVISIONED, but provisioned throughput is not set', () => {
Expand Down

0 comments on commit 9717a67

Please sign in to comment.