Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: cdk examples + e2e tests #353

Closed
saragerion opened this issue Dec 28, 2021 · 2 comments
Closed

Docs: cdk examples + e2e tests #353

saragerion opened this issue Dec 28, 2021 · 2 comments
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation logger This item relates to the Logger Utility

Comments

@saragerion
Copy link
Contributor

Description of the feature request

Similarly to what is done for Tracer and Metrics utilities, it would be helpful for developers to add these functionalities.

Problem statement

Summary of the feature

  • Add logger related examples in root folder
  • Add e2e tests in the package folder/scope

Code examples
N/A

Benefits for you and the wider AWS community
Better understand how to use the library, better testing coverage

Describe alternatives you've considered
N/A

Additional context
N/A

Related issues, RFCs

N/A

@saragerion saragerion added the triage This item has not been triaged by a maintainer, please wait label Dec 28, 2021
@saragerion saragerion added this to the beta-release milestone Dec 28, 2021
@saragerion saragerion added logger This item relates to the Logger Utility documentation Improvements or additions to documentation labels Dec 28, 2021
@ijemmy ijemmy self-assigned this Jan 19, 2022
@ijemmy
Copy link
Contributor

ijemmy commented Feb 15, 2022

We have e2e tests for logger now (PR #529)

@saragerion I understand that we have already had logger example in examples/cdk (here).

Or do you mean moving the examples from packages/logger/examples to examples/cdk? In that case, is this duplicated with #332 (which is on-hold for customer's feedback).

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Oct 19, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
@dreamorosi dreamorosi changed the title logger: cdk examples + e2e tests Docs: cdk examples + e2e tests Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation logger This item relates to the Logger Utility
Projects
None yet
Development

No branches or pull requests

3 participants