Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): LambdaFunctionUrl envelope assumes JSON string in body #3514

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix(parser): LambdaFunctionUrl envelope assumes JSON string in body #3514

merged 4 commits into from
Jan 23, 2025

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jan 23, 2025 •
edited
Loading

Summary

Changes

Please provide a summary of what's being changed

This PR fixes the issues of LambdaFunctionUrlEnvelope assumed body field was always a JSON string. I have changed the Envelope similar to ApiGatewayV2 impementation and moved the example events according to the new convention.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3199

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d self-assigned this Jan 23, 2025
@am29d am29d requested review from a team as code owners January 23, 2025 11:32
@boring-cyborg boring-cyborg bot added parser This item relates to the Parser Utility tests PRs that add or change tests labels Jan 23, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jan 23, 2025
@github-actions github-actions bot added the bug Something isn't working label Jan 23, 2025
dreamorosi
dreamorosi requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the envelope, left a few minor comments on the tests & test events.

One is a redundant test case (I think), and all the others are consistency/style.

packages/parser/tests/events/lambda/with-trailing-slash.json Outdated Show resolved Hide resolved
packages/parser/tests/unit/schema/lambda.test.ts Outdated Show resolved Hide resolved
packages/parser/tests/unit/schema/lambda.test.ts Show resolved Hide resolved
packages/parser/tests/unit/schema/lambda.test.ts Outdated Show resolved Hide resolved
packages/parser/tests/unit/schema/lambda.test.ts Outdated Show resolved Hide resolved
packages/parser/tests/unit/envelopes/lambda.test.ts Outdated Show resolved Hide resolved
packages/parser/tests/unit/envelopes/lambda.test.ts Outdated Show resolved Hide resolved
packages/parser/tests/unit/envelopes/lambda.test.ts Outdated Show resolved Hide resolved
packages/parser/tests/unit/envelopes/lambda.test.ts Outdated Show resolved Hide resolved
packages/parser/tests/unit/envelopes/lambda.test.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@am29d
Copy link
Contributor Author

am29d commented Jan 23, 2025

Thank for the review, I have addressed the test names and comments.

@am29d am29d requested a review from dreamorosi January 23, 2025 12:57
dreamorosi
dreamorosi approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the PR - onto the next one!

@dreamorosi dreamorosi merged commit 09aa287 into main Jan 23, 2025
38 checks passed
@dreamorosi dreamorosi deleted the fix/3199-funcationurl-envelope-body branch January 23, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@am29d am29d

Labels
bug Something isn't working parser This item relates to the Parser Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: LambdaFunctionUrlEnvelope assumes body is always a JSON string
2 participants
@am29d @dreamorosi