fix(parser): CloudWatch Log Envelope handles non-JSON #3505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR fixes the
CloudWatchEnvelope
built-in envelope so that it correctly handles log messages that are not JSON strings. The previous implementation forced the parsing to always attempt aJSON.parse
which would fail in the case of non-JSON-structured log messages.For example, parsing a series of log messages from an AWS Lambda function invocation would fail when encountering messages like this:
This PR fixes this behavior by removing the forced JSON parsing and instead letting the customer set the parsing if they know their
message
is JSON-structured, i.e.The PR also refactored the unit tests for both the schema & the envelope, as well as removing the usage of
Envelope
in favor of an implementation in theCloudWatchEnvelope
that now includes the correct full path in the error, i.e.The PR also adds a new custom error that is thrown when either the unzip or decode operations fail, since the error thrown by the standard library is rather opaque and a generic
Error
.While working on this PR I also removed another batch of test event files that were not used nor referenced anywhere.
Issue number: fixes #3225
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.