Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(maintenance): drop support for Node.js 16.x #2717

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat(maintenance): drop support for Node.js 16.x #2717

merged 4 commits into from
Jul 2, 2024

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR drops support for Node.js 16 for Powertools for AWS Lambda (TypeScript). As discussed in the linked issue, Node.js 16 has reached EOL and its corresponding AWS Lambda managed runtime has been marked as deprecated.

Below a list of changes included in the PR:

  • Remove Node.js 16 from test matrixes, test harnesses, scripts, etc.
  • Remove deprecated version from docs, comments, issue/PR templates
  • Removed deprecation banner from docs, replaced with v1 EOL
  • Raised baseline for Layer canary stack to Node.js 18
  • Removed nodejs16x from compatible runtimes in Lambda layer
  • Replaced usage of Object(someObject).hasOwnProperty(someProperty) with Object.hasOwn(someObject, someProperty) (MDN docs)
  • Removed polyfill for Error.cause (MDN docs) and
  • updated ParseError in Parser utility to use it, as well as every envelope
  • updated Logger log formatter to assume the option can exist
  • Removed conditional behavior around fetch in e2e tests since now it's present in all supported runtimes

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2223

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jul 1, 2024
@boring-cyborg boring-cyborg bot added automation This item relates to automation commons This item relates to the Commons Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline logger This item relates to the Logger Utility parameters This item relates to the Parameters Utility parser This item relates to the Parser Utility tests PRs that add or change tests labels Jul 1, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 1, 2024
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Jul 1, 2024
@dreamorosi dreamorosi marked this pull request as ready for review July 2, 2024 07:39
@dreamorosi dreamorosi requested review from a team as code owners July 2, 2024 07:39
@dreamorosi
Copy link
Contributor Author

Integration tests on this branch are passing: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/9757062917

am29d
am29d requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on keeping the track on all the places where node16 had a special treatment!

Few notes on default node version in various places, so we can settle on either 18 or 20.

packages/idempotency/tests/helpers/populateEnvironmentVariables.ts Show resolved Hide resolved
packages/jmespath/src/errors.ts Show resolved Hide resolved
packages/testing/tests/helpers/populateEnvironmentVariables.ts Show resolved Hide resolved
@dreamorosi dreamorosi requested a review from am29d July 2, 2024 09:07
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit e4eee73 into main Jul 2, 2024
13 checks passed
@dreamorosi dreamorosi deleted the feat/drop_nodejs16x branch July 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am29d am29d am29d approved these changes

Assignees

@dreamorosi dreamorosi

Labels
automation This item relates to automation commons This item relates to the Commons Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation feature PRs that introduce new features or minor changes internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline logger This item relates to the Logger Utility parameters This item relates to the Parameters Utility parser This item relates to the Parser Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: drop support for Node.js 16
2 participants
@dreamorosi @am29d