Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [Submitter] RenderSetupIncludeLights job parameter is inaccurate if the corresponding option variable is not set #206

Closed
jericht opened this issue Jan 7, 2025 · 0 comments · Fixed by #207
Assignees
Labels
bug Something isn't working

Comments

@jericht
Copy link
Contributor

jericht commented Jan 7, 2025

Describe the bug

The RenderSetupIncludeLights job parameter in the job bundle generated by the submitter is inaccurate if the corresponding option variable is not set. The current implementation uses the optionVar MEL command to check if the renderSetup_includeAllLights option variable is set, however if this variable is not set (e.g. by explicitly interacting with the Render Setup editor menu > Options > "Include all lights in each render layer by default" checkbox), the submitter will always report the option to be false, even if the checkbox is checked in Maya. This causes confusion when local renders include all lights, but renders on Deadline Cloud do not.

Expected Behaviour

RenderSetupIncludeLights in the generated job bundle should match the Render Setup editor menu > Options > "Include all lights in each render layer by default" checkbox state

Current Behaviour

It does not match the state if the renderSetup_includeAllLights option variable is not defined.

Reproduction Steps

  1. Open an empty Maya scene
  2. In the Render Setup editor menu > Options > "Include all lights in each render layer by default", make sure the option is checked
  3. In the MEL prompt, make sure the renderSetup_includeAllLights option variable is removed by running optionVar -remove renderSetup_includeAllLights
  4. Double check that the Render Setup editor menu > Options > "Include all lights in each render layer by default" is still checked (do not touch it, this will set the option variable again)
  5. Double double check, in the MEL prompt, make sure the renderSetup_includeAllLights option variable does not exist by running optionVar -ex renderSetup_includeAllLights. It should return 0
  6. Open the Deadline Cloud submitter and export the job bundle
  7. Open the job bundle's parameter_values.yaml file and verify that the RenderSetupIncludeLights option is false, which does not match the checkbox value in Maya

Environment

At minimum:

  1. Operating system: All
  2. Version of Maya: 2024
    3: Version of this package: 0.14.4
  3. If this is from a version installed by the Deadline Cloud Submitter installer, then what version of the submitter installer?
    • Not in my testing (macOS), but it will also happen in that case

Please share other details about your environment that you think might be relevant to reproducing the bug.

@jericht jericht added bug Something isn't working needs triage A new issue that needs a first look and removed needs triage A new issue that needs a first look labels Jan 7, 2025
@jericht jericht self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant