Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Support Blender 3.6 in integration tests #183

Open
miabatta opened this issue Feb 7, 2025 · 2 comments
Open

Maintenance: Support Blender 3.6 in integration tests #183

miabatta opened this issue Feb 7, 2025 · 2 comments
Labels
maintenance Changes to builds, tests, processes, or code that does not directly affect functionality

Comments

@miabatta
Copy link
Contributor

miabatta commented Feb 7, 2025

Description

The scene used in integration tests uses a colour profile only included in Blender 4.2. When opening the scene file in Blender 3.6, you see the console output:

Color management: scene view "AgX" not found, setting default "Standard".

This results in the output of running integration tests with a Blender 3.6 executable to be visually different enough from the expected images to fail the image comparison.

Blender 4.2 (from the expected images):
Image

Blender 3.6:
Image

Solution

We should either use a colour profile in each scene file that is included in both Blender versions, or have separate test cases per version.

@miabatta miabatta added the needs triage A new issue that needs a first look label Feb 7, 2025
@erico-aws erico-aws removed the needs triage A new issue that needs a first look label Feb 19, 2025
@erico-aws
Copy link
Contributor

Thanks for reporting this Mia.

@erico-aws erico-aws added the maintenance Changes to builds, tests, processes, or code that does not directly affect functionality label Feb 19, 2025
@edwards-aws
Copy link
Contributor

I quickly tried out changing the colour profile. There's still enough differences between the images in 3.6 and 4.2 that I think the fix here is to have sets of different expected images for all Blender major versions that support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to builds, tests, processes, or code that does not directly affect functionality
Projects
None yet
Development

No branches or pull requests

3 participants