Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom scopes to federated logins #297

Closed
ceich opened this issue Feb 16, 2018 · 9 comments
Closed

Add support for custom scopes to federated logins #297

ceich opened this issue Feb 16, 2018 · 9 comments
Labels
Auth Related to Auth components/category feature-request Request a new feature

Comments

@ceich
Copy link
Contributor

ceich commented Feb 16, 2018

What is the current behavior?

Scopes for federated logins are hardcoded:
Facebook: 'public_profile,email'
Google: 'profile email openid'
Amazon: 'profile'

What is the expected desired behavior?

Allow override of the defaults with new xxx_scope keys in the federated hash.

I have forked the repo and am willing to add support. Let me know if this would be welcome.

@powerful23
Copy link
Contributor

@ceich yeah sure that's a really good enhancement to the library.

@mlabieniec mlabieniec added the Auth Related to Auth components/category label Feb 22, 2018
@mlabieniec mlabieniec added the feature-request Request a new feature label Apr 2, 2018
@dcsena
Copy link

dcsena commented Sep 6, 2018

Any update on this? Definitely something I would like added

@stephenhuh
Copy link

if no ones working on this id like to pick it up

@peetss
Copy link

peetss commented Jan 5, 2019

If anyone has something I can NPM install that allows for this, I would be eternally grateful.

I tried forking the library, building it with the directions in the wiki then installing it with npm to no avail. Ended up ripping out the built-in Facebook login and replacing it with https://serverless-stack.com/chapters/facebook-login-with-cognito-using-aws-amplify.html which works great.

@undefobj
Copy link
Contributor

@peetss @stephenhuh @dcsena @ceich we are looking at an enhancement for Auth.federatedSignIn() at this time which could potentially address this use case. Please see the RFC here: #2716

I'd be interested in seeing what you expect the overloaded scope experience would look like in a more simplified API. Could you please comment in the RFC?

@peetss
Copy link

peetss commented Mar 26, 2019

I ended up not using custom scopes as they are quite a pain to get approval for on Facebook in particular. However, it would still be nice to pass additional scopes in optionally. Will check out the RFC.

@undefobj
Copy link
Contributor

undefobj commented May 4, 2019

Is this functionality still needed with the latest updates to the CLI supporting the OAuth/Hosted UI (where you can specify scopes in the OAuth config) as well as the library supporting OAuth with federatedSignIn() or can the issue be closed?

@ceich
Copy link
Contributor Author

ceich commented May 4, 2019

Agree it's ok to close.

@ceich ceich closed this as completed May 4, 2019
@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auth Related to Auth components/category feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

7 participants