Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 Vulnerability fix: bump xml-parser to v4.4.1 for V5 #13657

Closed
2 tasks
jackirvine97 opened this issue Jul 30, 2024 · 9 comments
Closed
2 tasks

V5 Vulnerability fix: bump xml-parser to v4.4.1 for V5 #13657

jackirvine97 opened this issue Jul 30, 2024 · 9 comments
Assignees
Labels
bug Something isn't working Core Related to core Amplify issues V5

Comments

@jackirvine97
Copy link

jackirvine97 commented Jul 30, 2024

Is this related to a new or existing framework?

React

Is this related to a new or existing API?

Authentication

Is this related to another service?

No response

Describe the feature you'd like to request

  • Amplify js v5 uses node library xml-parser < v4.4.1
  • xml parser <v4.4.1 is exposed to GHSA-mpg4-rc92-vx8v
  • this is preventing production deployments for apps using v5

Describe the solution you'd like

Given the complexity and time required to migrate from v5 to v6, can this dependency be bumped so v5 apps are not blocked from deployments and not exposed to this vulnerability

Describe alternatives you've considered

n/a

Additional context

n/a

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@jackirvine97 jackirvine97 added the pending-triage Issue is pending triage label Jul 30, 2024
@jackirvine97 jackirvine97 changed the title V5 Vulnerability Fix: bump xml-parser to v4.4.1 for V5 V5 Vulnerability fix: bump xml-parser to v4.4.1 for V5 Jul 30, 2024
@cwomack cwomack self-assigned this Jul 30, 2024
@cwomack cwomack added feature-request Request a new feature V5 Core Related to core Amplify issues and removed pending-triage Issue is pending triage labels Jul 30, 2024
@jackirvine97
Copy link
Author

jackirvine97 commented Jul 30, 2024

Is #13663 the resolution?

@cwomack
Copy link
Member

cwomack commented Jul 30, 2024

Hello, @jackirvine97 and thank you for opening this issue. As you already saw, PR #13663 is indeed the resolution to this! The release for this will happen within the next week, but we are working on getting it to build on the "unstable" branch. We'll update this issue when that's ready, as well as when the release happens that includes this.

@jackirvine97
Copy link
Author

Brilliant @cwomack , thank you so much for the update and for patching though this fix

@mcintoac-aws
Copy link

@cwomack Just wanting to double check that the resolution in PR #13663 is enough to fix the issue? There are exact dependency versions for various @AWS-SDK packages specified within some @aws-amplify packages that are also vulnerable, the @AWS-SDK packages have been updated to "3.621.0" and might require dependency updates in the amplify packages as well.

@jackirvine97
Copy link
Author

Other than upgrading to v6, skipping "high" vulnerabilities in my node audit run, or moving to a CICD where I can do a targeted ignore of CVEs, I assume there are no other workarounds? (I have a PRD patch hanging off this)

@cwomack cwomack added bug Something isn't working and removed feature-request Request a new feature labels Aug 1, 2024
@haverchuck
Copy link
Contributor

Some context can be found here: aws/aws-sdk-js-v3#6331 (comment)

@ashika112
Copy link
Member

Hi everyone, the fix for this is now released on version 5.3.21. Please let us know if there are any question or comments on the fix.

@navv-christofer-flores
Copy link

@ashika112 What about aws-amplify v6? I'm having this issue on the latest version too 6.5.0:

image

@ashika112
Copy link
Member

@navv-christofer-flores v6 has the fix as well. In your screenshot I see [email protected] that version does not have the vulnerability. it was the version the fix was released by fast-xml-parser library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core Related to core Amplify issues V5
Projects
None yet
Development

No branches or pull requests

6 participants