fix(appsync-modelgen-plugin): non model type with id field in java #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronZyLee
commented
Oct 13, 2021
| selectedType?: string, | ||
| generate: CodeGenGenerateEnum = CodeGenGenerateEnum.code, | ||
| usePipelinedTransformer: boolean = false, | ||
| ) => { |
| isTimestampFieldsAdded: true, | ||
| handleListNullabilityTransparently: true, | ||
| usePipelinedTransformer: usePipelinedTransformer, | ||
| }, |
| schema: string, | ||
| selectedType?: string, | ||
| generate: CodeGenGenerateEnum = CodeGenGenerateEnum.code, | ||
| ) => { |
| @@ -98,7 +115,7 @@ describe('AppSyncModelVisitor', () => { | |||
| it('Should generate a class a model with all optional fields except id field', () => { | |||
| const schema = /* GraphQL */ ` | |||
| type SimpleModel @model { | |||
| id: ID!, | |||
| id: ID! | |||
| author: String | ||
| book: String | ||
| } | ||
| `; |
| author: String | ||
| book: String | ||
| } | ||
| `; |
| author: String | ||
| book: String | ||
| } | ||
| `; |
| type ListContainer | ||
| @model | ||
| { | ||
| type ListContainer @model { |
| @@ -383,11 +398,11 @@ describe('AppSyncModelVisitor', () => { | |||
|
|
|||
| it('should generate class with non-default providers', () => { | |||
| const schema = /* GraphQL */ ` | |||
| type Employee @model @auth(rules: [{ allow: owner }, { allow: private, provider:"iam" } ]) { | |||
| type Employee @model @auth(rules: [{ allow: owner }, { allow: private, provider: "iam" }]) { | |||
| id: ID! | ||
| name: String! | ||
| address: String! | ||
| ssn: String @auth(rules: [{ allow: groups, provider:"oidc", groups: ["Admins"] }]) | ||
| ssn: String @auth(rules: [{ allow: groups, provider: "oidc", groups: ["Admins"] }]) |
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 85.53% 85.53% -0.01%
==========================================
Files 144 144
Lines 6609 6614 +5
Branches 1517 1553 +36
==========================================
+ Hits 5653 5657 +4
- Misses 875 883 +8
+ Partials 81 74 -7
Continue to review full report at Codecov.
|
dpilch
approved these changes
Oct 18, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Generate correct output for non-model type with
idfield defined.idis currently reserved field in model types but not in non-model typesIssue #, if available
fix #231
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.