Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync-modelgen-plugin): update Flutter ignored rules and add analysis note #248

Merged

Conversation

Jordan-Nelson
Copy link
Member

@Jordan-Nelson Jordan-Nelson commented Sep 30, 2021

Description of changes

  • Update the list of ignored lint rules
  • Add note about excluding files from analysis

Issue #, if available

#510

Description of how you validated changes

  • Tested against the updated snapshots
  • Tested in a sample app with default blog/post/comment schema

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner September 30, 2021 19:19
@Jordan-Nelson Jordan-Nelson requested a review from a team September 30, 2021 19:19
@@ -1,11 +1,16 @@
export const LOADER_CLASS_NAME = 'ModelProvider';
export const BASE_IMPORT_PACKAGES = [
'package:flutter/foundation.dart',
'package:amplify_datastore_plugin_interface/amplify_datastore_plugin_interface.dart'
'package:amplify_datastore_plugin_interface/amplify_datastore_plugin_interface.dart',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting changes here and at the end of the file were added automatically in a post commit hook

@codecov-commenter
Copy link

Codecov Report

Merging #248 (b5e4503) into master (87c1176) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     aws-amplify/amplify-flutter#248   +/-   ##
=======================================
  Coverage   85.52%   85.53%           
=======================================
  Files         144      144           
  Lines        6605     6609    +4     
  Branches     1517     1489   -28     
=======================================
+ Hits         5649     5653    +4     
  Misses        875      875           
  Partials       81       81           
Impacted Files Coverage Δ
...appsync-modelgen-plugin/src/configs/dart-config.ts 100.00% <100.00%> (ø)
...delgen-plugin/src/visitors/appsync-dart-visitor.ts 96.91% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b2bee...b5e4503. Read the comment docs.

Copy link
Contributor

@AaronZyLee AaronZyLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A temperate solution to fix the lint problems. LGTM 🍨

Copy link

@dnys1 dnys1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants