-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appsync-modelgen-plugin): update Flutter ignored rules and add analysis note #248
feat(appsync-modelgen-plugin): update Flutter ignored rules and add analysis note #248
Conversation
@@ -1,11 +1,16 @@ | |||
export const LOADER_CLASS_NAME = 'ModelProvider'; | |||
export const BASE_IMPORT_PACKAGES = [ | |||
'package:flutter/foundation.dart', | |||
'package:amplify_datastore_plugin_interface/amplify_datastore_plugin_interface.dart' | |||
'package:amplify_datastore_plugin_interface/amplify_datastore_plugin_interface.dart', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting changes here and at the end of the file were added automatically in a post commit hook
Codecov Report
@@ Coverage Diff @@
## master aws-amplify/amplify-flutter#248 +/- ##
=======================================
Coverage 85.52% 85.53%
=======================================
Files 144 144
Lines 6605 6609 +4
Branches 1517 1489 -28
=======================================
+ Hits 5649 5653 +4
Misses 875 875
Partials 81 81
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A temperate solution to fix the lint problems. LGTM 🍨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Description of changes
Issue #, if available
#510
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.